spaceship/lib/spaceship/test_flight/client.rb in fastlane-2.114.0.beta.20190116200018 vs spaceship/lib/spaceship/test_flight/client.rb in fastlane-2.114.0
- old
+ new
@@ -174,10 +174,12 @@
def testers_for_app(app_id: nil)
assert_required_params(__method__, binding)
page_size = 40 # that's enforced by the iTC servers
resulting_array = []
- initial_url = "providers/#{team_id}/apps/#{app_id}/testers?limit=#{page_size}&sort=email&order=asc"
+ # Sort order is set to `default` instead of `email`, because any other sort order breaks pagination
+ # when dealing with lots of anonymous (public link) testers: https://github.com/fastlane/fastlane/pull/13778
+ initial_url = "providers/#{team_id}/apps/#{app_id}/testers?limit=#{page_size}&sort=default&order=asc"
response = request(:get, initial_url)
link_from_response = proc do |r|
# I weep for Swift nil chaining
(l = r.headers['link']) && (m = l.match(/<(.*)>/)) && m.captures.first
end