precheck/lib/precheck/rules/unreachable_urls_rule.rb in fastlane-2.102.0 vs precheck/lib/precheck/rules/unreachable_urls_rule.rb in fastlane-2.103.0

- old
+ new

@@ -27,16 +27,16 @@ return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: "empty url") if url.empty? begin uri = Addressable::URI.parse(url) uri.fragment = nil - request = Faraday.new(URI.encode(uri.to_s)) do |connection| + request = Faraday.new(uri.normalize.to_s) do |connection| connection.use(FaradayMiddleware::FollowRedirects) connection.adapter(:net_http) end return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: url) unless request.head.status == 200 - rescue - UI.verbose("URL #{url} not reachable 😵") + rescue StandardError => e + UI.verbose("URL #{url} not reachable 😵: #{e.message}") # I can only return :fail here, but I also want to return #{url} return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "unreachable: #{url}") end return RuleReturn.new(validation_state: VALIDATION_STATES[:passed])