pilot/lib/pilot/tester_manager.rb in fastlane-2.51.0.beta.20170804010003 vs pilot/lib/pilot/tester_manager.rb in fastlane-2.51.0.beta.20170805010003

@@ -36,27 +36,29 @@
     end
 
     def find_tester(options)
       start(options)
 
-      tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
-      tester ||= Spaceship::Tunes::Tester::External.find(config[:email])
+      app_filter = (config[:apple_id] || config[:app_identifier])
+      app = find_app(app_filter: app_filter)
 
+      tester = find_app_tester(email: config[:email], app: app)
       UI.user_error!("Tester #{config[:email]} not found") unless tester
 
       describe_tester(tester)
       return tester
     end
 
     def remove_tester(options)
       start(options)
 
-      tester = Spaceship::Tunes::Tester::External.find(config[:email])
-      tester ||= Spaceship::Tunes::Tester::Internal.find(config[:email])
-      UI.user_error!("Tester not found: #{config[:email]}") if tester.nil?
+      app_filter = (config[:apple_id] || config[:app_identifier])
+      app = find_app(app_filter: app_filter)
 
-      app = find_app(app_filter: config[:apple_id] || config[:app_identifier])
+      tester = find_app_tester(email: config[:email], app: app)
+      UI.user_error!("Tester #{config[:email]} not found") unless tester
+
       unless app
         tester.delete!
         UI.success("Successfully removed tester #{tester.email} from Users and Roles")
         return
       end
@@ -221,19 +223,19 @@
 
       rows << ["First name", tester.first_name]
       rows << ["Last name", tester.last_name]
       rows << ["Email", tester.email]
 
-      if tester.groups.length > 0
+      if tester.groups.to_s.length > 0
         rows << ["Groups", tester.groups_list]
       end
 
       if tester.latest_install_date
         rows << ["Latest Version", tester.full_version]
         rows << ["Latest Install Date", tester.pretty_install_date]
       end
 
-      if tester.devices.length == 0
+      if tester.devices.to_s.length == 0
         rows << ["Devices", "No devices"]
       else
         rows << ["#{tester.devices.count} Devices", ""]
         tester.devices.each do |device|
           current = "\u2022 #{device['model']}, iOS #{device['osVersion']}"