fastlane/lib/fastlane/actions/slather.rb in fastlane-2.122.0.beta.20190501200015 vs fastlane/lib/fastlane/actions/slather.rb in fastlane-2.122.0.beta.20190502200046
- old
+ new
@@ -69,10 +69,21 @@
if params[:proj] || has_config_file
true
else
UI.user_error!("You have to provide a project with `:proj` or use a .slather.yml")
end
+
+ # for backwards compatibility when :binary_file type was Boolean
+ if params[:binary_file] == true || params[:binary_file] == false
+ params[:binary_file] = nil
+ end
+
+ # :binary_file validation was skipped for backwards compatibility with Boolean. If a
+ # Boolean was passed in, it has now been removed. Revalidate :binary_file
+ binary_file_options = available_options.find { |a| a.key == :binary_file }
+ binary_file_options.skip_type_validation = false
+ binary_file_options.verify!(params[:binary_file])
end
def self.build_command(params)
command = []
command.push("bundle exec") if params[:use_bundle_exec] && shell_out_should_use_bundle_exec?
@@ -250,11 +261,11 @@
is_string: false,
default_value: false),
FastlaneCore::ConfigItem.new(key: :binary_file,
env_name: "FL_SLATHER_BINARY_FILE",
description: "Binary file name to be used for code coverage",
- is_string: false,
- default_value: false),
+ skip_type_validation: true, # skipping validation for backwards compatibility with Boolean type
+ optional: true),
FastlaneCore::ConfigItem.new(key: :arch,
env_name: "FL_SLATHER_ARCH",
description: "Specify which architecture the binary file is in. Needed for universal binaries",
optional: true),
FastlaneCore::ConfigItem.new(key: :source_files,