lib/faraday/zipkin.rb in faraday-zipkin-0.2.0 vs lib/faraday/zipkin.rb in faraday-zipkin-0.2.1

@@ -27,14 +27,20 @@
         url = env[:url].respond_to?(:host) ? env[:url] : URI.parse(env[:url].to_s)
         service_name = @service_name || url.host.split('.').first # default to url-derived service name
         endpoint = ::Trace::Endpoint.new(::Trace::Endpoint.host_to_i32(url.host), url.port, service_name)
 
         ::Trace.push(trace_id.next_id) do
+          # annotate with method (GET/POST/etc.) and uri path
+          ::Trace.set_rpc_name(env[:method].to_s.upcase)
+          ::Trace.record(::Trace::BinaryAnnotation.new("http.uri", url.path, "STRING", endpoint))
           ::Trace.record(::Trace::Annotation.new(::Trace::Annotation::CLIENT_SEND, endpoint))
           B3_HEADERS.each do |method, header|
             env[:request_headers][header] = ::Trace.id.send(method).to_s
           end
-          result = @app.call(env)
+          result = @app.call(env).on_complete do |renv|
+            # record HTTP status code on response
+            ::Trace.record(::Trace::BinaryAnnotation.new("http.status", renv[:status], "I16", endpoint))
+          end
           ::Trace.record(::Trace::Annotation.new(::Trace::Annotation::CLIENT_RECV, endpoint))
           result
         end
       end
     end