src/main/java/org/embulk/input/jira/util/JiraUtil.java in embulk-input-jira-0.2.8 vs src/main/java/org/embulk/input/jira/util/JiraUtil.java in embulk-input-jira-0.2.9
- old
+ new
@@ -7,10 +7,11 @@
import org.apache.http.client.methods.CloseableHttpResponse;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.HttpClientBuilder;
import org.embulk.config.ConfigException;
+import org.embulk.config.ConfigSource;
import org.embulk.input.jira.Issue;
import org.embulk.input.jira.JiraInputPlugin.PluginTask;
import org.embulk.spi.Column;
import org.embulk.spi.ColumnConfig;
import org.embulk.spi.ColumnVisitor;
@@ -35,36 +36,36 @@
public final class JiraUtil
{
private JiraUtil() {}
- public static int calculateTotalPage(int totalCount, int resultPerPage)
+ public static int calculateTotalPage(final int totalCount, final int resultPerPage)
{
return (int) Math.ceil((double) totalCount / resultPerPage);
}
- public static String buildPermissionUrl(String url)
+ public static String buildPermissionUrl(final String url)
{
return UriBuilder.fromUri(url).path(CREDENTIAL_URI_PATH).build().toString();
}
- public static String buildSearchUrl(String url)
+ public static String buildSearchUrl(final String url)
{
return UriBuilder.fromUri(url).path(SEARCH_URI_PATH).build().toString();
}
public static void validateTaskConfig(final PluginTask task)
{
- String username = task.getUsername();
+ final String username = task.getUsername();
if (isNullOrEmpty(username)) {
throw new ConfigException("Username or email could not be empty");
}
- String password = task.getPassword();
+ final String password = task.getPassword();
if (isNullOrEmpty(password)) {
throw new ConfigException("Password could not be empty");
}
- String uri = task.getUri();
+ final String uri = task.getUri();
if (isNullOrEmpty(uri)) {
throw new ConfigException("JIRA API endpoint could not be empty");
}
try (CloseableHttpClient client = HttpClientBuilder.create()
.setDefaultRequestConfig(RequestConfig.custom()
@@ -72,120 +73,119 @@
.setConnectionRequestTimeout(HTTP_TIMEOUT)
.setSocketTimeout(HTTP_TIMEOUT)
.setCookieSpec(CookieSpecs.STANDARD)
.build())
.build()) {
- HttpGet request = new HttpGet(uri);
+ final HttpGet request = new HttpGet(uri);
try (CloseableHttpResponse response = client.execute(request)) {
response.getStatusLine().getStatusCode();
}
}
catch (IOException | IllegalArgumentException e) {
throw new ConfigException("JIRA API endpoint is incorrect or not available");
}
- int retryInitialWaitSec = task.getInitialRetryIntervalMillis();
+ final int retryInitialWaitSec = task.getInitialRetryIntervalMillis();
if (retryInitialWaitSec < 1) {
throw new ConfigException("Initial retry delay should be equal or greater than 1");
}
- int retryLimit = task.getRetryLimit();
+ final int retryLimit = task.getRetryLimit();
if (retryLimit < 0 || retryLimit > 10) {
throw new ConfigException("Retry limit should between 0 and 10");
}
}
/*
* For getting the timestamp value of the node
* Sometime if the parser could not parse the value then return null
* */
- private static Timestamp getTimestampValue(PluginTask task, Column column, String value)
+ private static Timestamp getTimestampValue(final PluginTask task, final Column column, final String value)
{
- List<ColumnConfig> columnConfigs = task.getColumns().getColumns();
+ final List<ColumnConfig> columnConfigs = task.getColumns().getColumns();
String pattern = DEFAULT_TIMESTAMP_PATTERN;
- for (ColumnConfig config : columnConfigs) {
- if (config.getName().equals(column.getName())
- && config.getConfigSource() != null
- && config.getConfigSource().getObjectNode() != null
- && config.getConfigSource().getObjectNode().get("format") != null
- && config.getConfigSource().getObjectNode().get("format").isTextual()) {
- pattern = config.getConfigSource().getObjectNode().get("format").asText();
+ for (final ColumnConfig columnConfig : columnConfigs) {
+ final ConfigSource columnConfigSource = columnConfig.getConfigSource();
+ if (columnConfig.getName().equals(column.getName())
+ && columnConfigSource != null
+ && columnConfigSource.has("format")) {
+ pattern = columnConfigSource.get(String.class, "format");
break;
}
}
- TimestampParser parser = TimestampParser.of(pattern, "UTC");
+ final TimestampParser parser = TimestampParser.of(pattern, "UTC");
Timestamp result = null;
try {
result = parser.parse(value);
}
- catch (Exception e) {
+ catch (final Exception e) {
}
return result;
}
/*
* For getting the Long value of the node
* Sometime if error occurs (i.e a JSON value but user modified it as long) then return null
* */
- private static Long getLongValue(JsonElement value)
+ private static Long getLongValue(final JsonElement value)
{
Long result = null;
try {
result = value.getAsLong();
}
- catch (Exception e) {
+ catch (final Exception e) {
}
return result;
}
/*
* For getting the Double value of the node
* Sometime if error occurs (i.e a JSON value but user modified it as double) then return null
* */
- private static Double getDoubleValue(JsonElement value)
+ private static Double getDoubleValue(final JsonElement value)
{
Double result = null;
try {
result = value.getAsDouble();
}
- catch (Exception e) {
+ catch (final Exception e) {
}
return result;
}
/*
* For getting the Boolean value of the node
* Sometime if error occurs (i.e a JSON value but user modified it as boolean) then return null
* */
- private static Boolean getBooleanValue(JsonElement value)
+ private static Boolean getBooleanValue(final JsonElement value)
{
Boolean result = null;
try {
result = value.getAsBoolean();
}
- catch (Exception e) {
+ catch (final Exception e) {
}
return result;
}
- public static void addRecord(Issue issue, Schema schema, PluginTask task, PageBuilder pageBuilder)
+ public static void addRecord(final Issue issue, final Schema schema, final PluginTask task, final PageBuilder pageBuilder)
{
schema.visitColumns(new ColumnVisitor() {
@Override
- public void jsonColumn(Column column)
+ public void jsonColumn(final Column column)
{
- JsonElement data = issue.getValue(column.getName());
+ final JsonElement data = issue.getValue(column.getName());
if (data.isJsonNull() || data.isJsonPrimitive()) {
pageBuilder.setNull(column);
}
else {
pageBuilder.setJson(column, new JsonParser().parse(data.toString()));
}
}
@Override
- public void stringColumn(Column column)
+ public void stringColumn(final Column column)
{
- JsonElement data = issue.getValue(column.getName());
+ final JsonElement data = issue.getValue(column.getName());
if (data.isJsonNull()) {
pageBuilder.setNull(column);
}
else if (data.isJsonPrimitive()) {
pageBuilder.setString(column, data.getAsString());
@@ -206,54 +206,54 @@
pageBuilder.setString(column, data.toString());
}
}
@Override
- public void timestampColumn(Column column)
+ public void timestampColumn(final Column column)
{
- JsonElement data = issue.getValue(column.getName());
+ final JsonElement data = issue.getValue(column.getName());
if (data.isJsonNull() || data.isJsonObject() || data.isJsonArray()) {
pageBuilder.setNull(column);
}
else {
- Timestamp value = getTimestampValue(task, column, data.getAsString());
+ final Timestamp value = getTimestampValue(task, column, data.getAsString());
if (value == null) {
pageBuilder.setNull(column);
}
else {
pageBuilder.setTimestamp(column, value);
}
}
}
@Override
- public void booleanColumn(Column column)
+ public void booleanColumn(final Column column)
{
- Boolean value = getBooleanValue(issue.getValue(column.getName()));
+ final Boolean value = getBooleanValue(issue.getValue(column.getName()));
if (value == null) {
pageBuilder.setNull(column);
}
else {
pageBuilder.setBoolean(column, value);
}
}
@Override
- public void longColumn(Column column)
+ public void longColumn(final Column column)
{
- Long value = getLongValue(issue.getValue(column.getName()));
+ final Long value = getLongValue(issue.getValue(column.getName()));
if (value == null) {
pageBuilder.setNull(column);
}
else {
pageBuilder.setLong(column, value);
}
}
@Override
- public void doubleColumn(Column column)
+ public void doubleColumn(final Column column)
{
- Double value = getDoubleValue(issue.getValue(column.getName()));
+ final Double value = getDoubleValue(issue.getValue(column.getName()));
if (value == null) {
pageBuilder.setNull(column);
}
else {
pageBuilder.setDouble(column, value);