lib/elastic_apm/stacktrace.rb in elastic-apm-0.6.1 vs lib/elastic_apm/stacktrace.rb in elastic-apm-0.6.2

@@ -69,41 +69,48 @@
       return true if abs_path.match(JRUBY_ORG_REGEX)
 
       false
     end
 
-    # rubocop:disable Metrics/MethodLength
+    class << self
+      attr_accessor :frame_cache
+    end
+
+    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     def build_frame(config, line, type)
-      abs_path, lineno, function, _module_name = parse_line(line)
+      # TODO: Eventually move this to agent 'context'
+      self.class.frame_cache ||= Util::LruCache.new(2048) do |cache, keys|
+        line, type = keys
+        abs_path, lineno, function, _module_name = parse_line(line)
 
-      frame = Frame.new
-      frame.abs_path = abs_path
-      frame.filename = strip_load_path(abs_path)
-      frame.function = function
-      frame.lineno = lineno.to_i
-      frame.library_frame = library_frame?(config, abs_path)
+        frame = Frame.new
+        frame.abs_path = abs_path
+        frame.filename = strip_load_path(abs_path)
+        frame.function = function
+        frame.lineno = lineno.to_i
+        frame.library_frame = library_frame?(config, abs_path)
 
-      line_count =
-        context_lines_for(config, type, library_frame: frame.library_frame)
-      frame.build_context line_count
+        line_count =
+          context_lines_for(config, type, library_frame: frame.library_frame)
+        frame.build_context line_count
 
-      frame
+        cache[[line, type]] = frame
+      end
+
+      self.class.frame_cache[[line, type]]
     end
-    # rubocop:enable Metrics/MethodLength
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
     def strip_load_path(path)
-      return nil unless path
+      return nil if path.nil?
 
       prefix =
         $LOAD_PATH
         .map(&:to_s)
         .select { |s| path.start_with?(s) }
-        .sort_by(&:length)
-        .last
+        .max_by(&:length)
 
-      return path unless prefix
-
-      path[prefix.chomp(File::SEPARATOR).length + 1..-1]
+      prefix ? path[prefix.chomp(File::SEPARATOR).length + 1..-1] : path
     end
 
     def context_lines_for(config, type, library_frame:)
       key = "source_lines_#{type}_#{library_frame ? 'library' : 'app'}_frames"
       config.send(key.to_sym)