CONTRIBUTING.md in doorkeeper-2.2.0 vs CONTRIBUTING.md in doorkeeper-2.2.1
- old
+ new
@@ -1,9 +1,12 @@
# Contributing
-We love pull requests. Here's a quick guide.
+We love pull requests from everyone. By participating in this project, you agree
+to abide by the thoughtbot [code of conduct].
+[code of conduct]: https://thoughtbot.com/open-source-code-of-conduct
+
Fork, then clone the repo:
git clone git@github.com:your-username/doorkeeper.git
Set up Ruby dependencies via Bundler
@@ -12,24 +15,31 @@
Make sure the tests pass:
rake
-Make your change. Add tests for your change. Make the tests pass:
+Make your change.
+Write tests.
+Follow our [style guide][style].
+Make the tests pass:
+[style]: https://github.com/thoughtbot/guides/tree/master/style
+
rake
-Push to your fork and submit a pull request.
+Write a [good commit message][commit].
+Push to your fork.
+[Submit a pull request][pr].
-At this point you're waiting on us. We like to at least comment on pull requests
-within three business days (and, typically, one business day). We may suggest
-some changes or improvements or alternatives.
+[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[pr]: https://github.com/doorkeeper-gem/doorkeeper/compare/
-Some things that will increase the chance that your pull request is accepted:
+If [Hound] catches style violations,
+fix them.
-* Write tests.
-* Follow our [style guide][style]. Address Hound CI comments unless you have a
- good reason not to.
-* Write a [good commit message][commit].
+[hound]: https://houndci.com
-[style]: https://github.com/thoughtbot/guides/tree/master/style
-[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+Wait for us.
+We try to at least comment on pull requests within one business day.
+We may suggest changes.
+
+Thank you for your contribution!