lib/doggy/cli/edit.rb in doggy-2.0.42 vs lib/doggy/cli/edit.rb in doggy-2.1.0

@@ -1,20 +1,21 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 module Doggy
   class CLI::Edit
     def initialize(options, param)
       @options = options
       @param   = param
     end
 
     def run
       resource = Doggy::Model.find_local(@param)
-      return Doggy.ui.error("Could not find resource with #{ @param }") unless resource
+      return Doggy.ui.error("Could not find resource with #{@param}") unless resource
 
       forked_resource = fork(resource)
-      system("open '#{ forked_resource.human_edit_url }'")
+      system("open '#{forked_resource.human_edit_url}'")
       wait_for_edit
 
       new_resource = Doggy::Model.infer_type(resource.attributes).find(forked_resource.id)
       new_resource.id = resource.id
       if new_resource.is_a?(Doggy::Models::Dashboard)
@@ -32,28 +33,26 @@
     end
 
     private
 
     def wait_for_edit
-      while !Doggy.ui.yes?('Are you done editing?(Y/N)') do
-        Doggy.ui.say "run, rabbit run / dig that hole, forget the sun / and when at last the work is done / don't sit down / it's time to dig another one"
-      end
+      Doggy.ui.say("run, rabbit run / dig that hole, forget the sun / and when at last the work is done / don't sit down / it's time to dig another one") until Doggy.ui.yes?('Are you done editing?(Y/N)')
     end
 
     def fork(resource)
       salt = Doggy.random_word
       forked_resource = resource.dup
       forked_resource.id = nil
       forked_resource.refute_read_only!
-      if resource.class.to_s.downcase =~ /dashboard/
-        forked_resource.title = "[#{ salt }] " + forked_resource.title
-        forked_resource.description = "[fork of #{ resource.id }] " + forked_resource.title
-      elsif resource.class.to_s.downcase =~ /screen/
-        forked_resource.board_title = "[#{ salt }] " + forked_resource.board_title
-      elsif resource.class.to_s.downcase =~ /monitor/
-        forked_resource.name = "[#{ salt }] " + forked_resource.name
+      if /dashboard/.match?(resource.class.to_s.downcase)
+        forked_resource.title = "[#{salt}] " + forked_resource.title
+        forked_resource.description = "[fork of #{resource.id}] " + forked_resource.title
+      elsif /screen/.match?(resource.class.to_s.downcase)
+        forked_resource.board_title = "[#{salt}] " + forked_resource.board_title
+      elsif /monitor/.match?(resource.class.to_s.downcase)
+        forked_resource.name = "[#{salt}] " + forked_resource.name
       else
-        raise StandardError.new('Unknown resource type, cannot edit.')
+        raise StandardError, 'Unknown resource type, cannot edit.'
       end
       forked_resource.save
       forked_resource
     end
   end