.rubocop_dnsimple.yml in dnsimple-4.1.0 vs .rubocop_dnsimple.yml in dnsimple-4.2.0

- old
+ new

@@ -12,20 +12,31 @@ # else # do_else # end # Lint/EndAlignment: - AlignWith: variable + EnforcedStyleAlignWith: variable # [codesmell] Metrics/AbcSize: Enabled: false Exclude: - 'spec/**/*_spec.rb' - 'test/**/*_test.rb' # [codesmell] +Metrics/BlockLength: + Enabled: false + +# [codesmell] +Metrics/CyclomaticComplexity: + Enabled: false + Exclude: + - 'spec/**/*_spec.rb' + - 'test/**/*_test.rb' + +# [codesmell] Metrics/ClassLength: Enabled: false Exclude: - 'spec/**/*_spec.rb' - 'test/**/*_test.rb' @@ -52,10 +63,19 @@ Exclude: - 'spec/**/*_spec.rb' - 'test/**/*_test.rb' # [codesmell] +Metrics/ParameterLists: + Enabled: false + Max: 5 + +# [codesmell] +Metrics/PerceivedComplexity: + Enabled: false + +# [codesmell] # I don't really get the point of this cop. Performance/RedundantMerge: Enabled: false # Do not use "and" or "or" in conditionals, but for readability we can use it @@ -86,11 +106,11 @@ # else # do_else # end # Style/CaseIndentation: - IndentWhenRelativeTo: end + EnforcedStyle: end # I was a big fan of leading, but trailing seems to be more commonly adopted. # At least at the time being. Style/DotPosition: EnforcedStyle: trailing @@ -119,10 +139,15 @@ # In most cases, a space is nice. Sometimes, it's not. # Just be consistent with the rest of the surrounding code. Style/EmptyLinesAroundModuleBody: Enabled: false +# There is no specific preference for empty methods. +# One-line methods are not exceptionally nice in Ruby. Just ignore this cop for now. +Style/EmptyMethod: + Enabled: false + # I personally don't care about the format style. # In most cases I like to use %, but not at the point I want to enforce it # as a convention in the entire code. Style/FormatString: Enabled: false @@ -162,10 +187,20 @@ # [codesmell] # It's not always that bad. Style/IfInsideElse: Enabled: false +# module_function doesn't respect the visibility of the methods, +# and doesn't work well when the module contain both public/private methods. +Style/ModuleFunction: + Enabled: false + +Style/MultilineBlockChain: + Exclude: + # RSpec uses multi-line blocks for certain features + - 'spec/**/*_spec.rb' + # Multi-line differs from standard indentation, they are indented twice. Style/MultilineMethodCallIndentation: EnforcedStyle: indented IndentationWidth: 4 @@ -193,10 +228,21 @@ # There are cases were the inline rescue is ok. We can either downgrade the severity, # or rely on the developer judgement on a case-by-case basis. Style/RescueModifier: Enabled: false +# Sorry, but using trailing spaces helps readability. +# +# %w( foo bar ) +# +# looks better to me than +# +# %w( foo bar ) +# +Style/SpaceInsidePercentLiteralDelimiters: + Enabled: false + # We don't have a preference. Style/SpecialGlobalVars: Enabled: false EnforcedStyle: use_perl_names @@ -218,5 +264,9 @@ # def self.default=(value) # @default = value # end # IgnoreClassMethods: true + +Style/WordArray: + EnforcedStyle: percent + MinSize: 3