schema.rb in dbf-3.1.2

- old
+ new

@@ -1,8 +1,19 @@
 module DBF
   # The Schema module is mixin for the Table class
   module Schema
+    FORMATS = [:activerecord, :json, :sequel].freeze
+
+    OTHER_DATA_TYPES = {
+      'Y' => ':decimal, :precision => 15, :scale => 4',
+      'D' => ':date',
+      'T' => ':datetime',
+      'L' => ':boolean',
+      'M' => ':text',
+      'B' => ':binary'
+    }.freeze
+
     # Generate an ActiveRecord::Schema
     #
     # xBase data types are converted to generic types as follows:
     # - Number columns with no decimals are converted to :integer
     # - Number columns with decimals are converted to :float
@@ -22,43 +33,45 @@
     #   end
     #
     # @param [Symbol] format Valid options are :activerecord and :json
     # @return [String]
     def schema(format = :activerecord, table_only = false)
-      supported_formats = [:activerecord, :json, :sequel]
-      if supported_formats.include?(format)
-        send("#{format}_schema", table_only)
-      else
-        raise ArgumentError
-      end
+      schema_method_name = schema_name(format)
+      send(schema_method_name, table_only)
+    rescue NameError
+      raise ArgumentError, ":#{format} is not a valid schema. Valid schemas are: #{FORMATS.join(', ')}."
     end
 
-    def activerecord_schema(_table_only = false) # nodoc
+    def schema_name(format) # :nodoc:
+      "#{format}_schema"
+    end
+
+    def activerecord_schema(_table_only = false) # :nodoc:
       s = "ActiveRecord::Schema.define do\n"
       s << "  create_table \"#{name}\" do |t|\n"
       columns.each do |column|
         s << "    t.column #{activerecord_schema_definition(column)}"
       end
       s << "  end\nend"
       s
     end
 
-    def sequel_schema(table_only = false) # nodoc
+    def sequel_schema(table_only = false) # :nodoc:
       s = ''
       s << "Sequel.migration do\n" unless table_only
       s << "  change do\n " unless table_only
       s << "    create_table(:#{name}) do\n"
       columns.each do |column|
         s << "      column #{sequel_schema_definition(column)}"
       end
       s << "    end\n"
-      s << "  end\n"  unless table_only
-      s << "end\n"  unless table_only
+      s << "  end\n" unless table_only
+      s << "end\n" unless table_only
       s
     end
 
-    def json_schema(_table_only = false) # nodoc
+    def json_schema(_table_only = false) # :nodoc:
       columns.map(&:to_hash).to_json
     end
 
     # ActiveRecord schema definition
     #
@@ -74,33 +87,29 @@
     # @return [String]
     def sequel_schema_definition(column)
       ":#{column.underscored_name}, #{schema_data_type(column, :sequel)}\n"
     end
 
-    def schema_data_type(column, format = :activerecord) # nodoc
+    def schema_data_type(column, format = :activerecord) # :nodoc:
       case column.type
-      when 'N', 'F'
-        column.decimal > 0 ? ':float' : ':integer'
-      when 'I'
-        ':integer'
-      when 'Y'
-        ':decimal, :precision => 15, :scale => 4'
-      when 'D'
-        ':date'
-      when 'T'
-        ':datetime'
-      when 'L'
-        ':boolean'
-      when 'M'
-        ':text'
-      when 'B'
-        ':binary'
+      when *%w[N F I]
+        number_data_type(column)
+      when *%w[Y D T L M B]
+        OTHER_DATA_TYPES[column.type]
       else
-        if format == :sequel
-          ":varchar, :size => #{column.length}"
-        else
-          ":string, :limit => #{column.length}"
-        end
+        string_data_format(format, column)
+      end
+    end
+
+    def number_data_type(column)
+      column.decimal > 0 ? ':float' : ':integer'
+    end
+
+    def string_data_format(format, column)
+      if format == :sequel
+        ":varchar, :size => #{column.length}"
+      else
+        ":string, :limit => #{column.length}"
       end
     end
   end
 end