spec/swiftformat/plugin_spec.rb in danger-swiftformat-0.0.3 vs spec/swiftformat/plugin_spec.rb in danger-swiftformat-0.1.0
- old
+ new
@@ -29,17 +29,40 @@
expect(@sut.swiftformat).to eq(swiftformat)
end
end
+ context "with additional_swiftformat_args" do
+ let(:additional_swiftformat_args) { "--indent tab --self insert" }
+ let(:success_output) { { errors: [], stats: { run_time: "0.08s" } } }
+
+ it "should pass the additional flags to swiftformat" do
+ allow(@sut.git).to receive(:added_files).and_return(["Added.swift"])
+ allow(@sut.git).to receive(:modified_files).and_return(["Modified.swift"])
+ allow(@sut.git).to receive(:deleted_files).and_return(["Deleted.swift"])
+ allow_any_instance_of(SwiftFormat).to receive(:installed?).and_return(true)
+ allow_any_instance_of(SwiftFormat).to receive(:check_format)
+ .with(%w(Added.swift Modified.swift), additional_swiftformat_args)
+ .and_return(success_output)
+
+ @sut.additional_swiftformat_args = additional_swiftformat_args
+
+ @sut.check_format(fail_on_error: true)
+
+ status = @sut.status_report
+ expect(status[:errors]).to be_empty
+ expect(status[:markdowns]).to be_empty
+ end
+ end
+
describe "#check_format" do
let(:success_output) { { errors: [], stats: { run_time: "0.08s" } } }
let(:error_output) { { errors: [{ file: "Modified.swift", rules: %w(firstRule secondRule) }], stats: { run_time: "0.16s" } } }
-
context "when there are no swift files to check" do
before do
+ allow_any_instance_of(SwiftFormat).to receive(:installed?).and_return(true)
allow(@sut.git).to receive(:added_files).and_return(["Added.m"])
allow(@sut.git).to receive(:modified_files).and_return(["Modified.m"])
allow(@sut.git).to receive(:deleted_files).and_return(["Deleted.m"])
end
@@ -60,11 +83,11 @@
allow(@sut.git).to receive(:deleted_files).and_return(["Deleted.swift"])
end
context "when swiftformat does not find any errors" do
before do
- allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift)).and_return(success_output)
+ allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift), nil).and_return(success_output)
end
it "should not do anything" do
@sut.check_format(fail_on_error: true)
@@ -74,10 +97,10 @@
end
end
context "when swiftformat finds errors" do
before do
- allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift)).and_return(error_output)
+ allow_any_instance_of(SwiftFormat).to receive(:check_format).with(%w(Added.swift Modified.swift), nil).and_return(error_output)
end
it "should output some markdown and error if fail_on_error is true" do
@sut.check_format(fail_on_error: true)