spec/pmd_spec.rb in danger-pmd-0.1.0 vs spec/pmd_spec.rb in danger-pmd-0.1.1

@@ -27,11 +27,11 @@
       it "Check default report files paths" do
         expect(@pmd.report_files).to eq(["app/build/reports/pmd/pmd.xml"])
       end
 
       it "Set custom report files paths" do
-        custom_report_paths = %w(custom-path/pmd_report_1.xml custom-path/pmd_report_2.xml)
+        custom_report_paths = ["custom-path/pmd_report_1.xml", "custom-path/pmd_report_2.xml"]
         @pmd.report_files = custom_report_paths
         expect(@pmd.report_files).to eq(custom_report_paths)
       end
 
       it "Check default Gradle task" do
@@ -42,20 +42,20 @@
         custom_task = "pmdStagingDebug"
         @pmd.gradle_task = custom_task
         expect(@pmd.gradle_task).to eq(custom_task)
       end
 
+      it "Check default skip Gradle task" do
+        expect(@pmd.skip_gradle_task).to eq(false)
+      end
+
       it "Skip Gradle task" do
         skip_gradle_task = true
         @pmd.skip_gradle_task = skip_gradle_task
         expect(@pmd.skip_gradle_task).to eq(skip_gradle_task)
       end
 
-      it "Check default skip Gradle task" do
-        expect(@pmd.skip_gradle_task).to eq(false)
-      end
-
       it "Report with report file" do
         target_files = [
           "/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java",
           "/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java",
           "/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java",
@@ -161,11 +161,11 @@
           "/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java",
           "/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java"
         ]
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
 
-        @pmd.report_files = %w(spec/fixtures/pmd_report.xml spec/fixtures/**/pmd_sub_report.xml)
+        @pmd.report_files = ["spec/fixtures/pmd_report.xml", "spec/fixtures/**/pmd_sub_report.xml"]
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report
         expect(pmd_issues).not_to be_nil
         expect(pmd_issues.length).to be(6)
@@ -255,10 +255,11 @@
         @pmd.report_file = "spec/fixtures/custom/pmd_report.xml"
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report
         expect(pmd_issues).not_to be_nil
-        expect(pmd_issues.length).to be(0)
+        expect(pmd_issues.length).to be(1)
+        expect(pmd_issues[0]).to eq("Could not find matching PMD report files for [\"spec/fixtures/custom/pmd_report.xml\"] inside current directory")
       end
     end
   end
 end