jacoco_spec.rb in danger-jacoco-instacart-0.1.13

- old
+ new

@@ -18,17 +18,21 @@
     describe 'with Dangerfile' do
       before do
         @dangerfile = testing_dangerfile
         @my_plugin = @dangerfile.jacoco
 
+        modified_files = ['src/java/com/example/CachedRepository.java']
+        added_files = ['src/java/io/sample/UseCase.java']
+
+        allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
+        allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
         allow(File).to receive(:open).and_call_original
       end
 
       it :report do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
 
         @my_plugin.report path_a
 
@@ -41,11 +45,10 @@
       end
 
       it 'creates supplied status file upon failure' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 100
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.file_to_create_on_failure = 'kmm.txt'
 
         expect(File).to receive(:open).with('kmm.txt', 'w')
@@ -53,32 +56,29 @@
       end
 
       it 'creates default status file upon failure' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 60
 
         expect(File).to receive(:open).with('danger_jacoco_failure_status_file.txt', 'w')
         @my_plugin.report path_a
       end
 
       it 'does _not_ create status file upon success' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 40
         @my_plugin.file_to_create_on_failure = 'kmm.txt'
 
         expect(File).to_not receive(:open).with('kmm.txt', 'w')
         @my_plugin.report path_a
       end
 
       it 'test regex class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { '.*Repository' => 60 }
 
         @my_plugin.report path_a
 
@@ -86,11 +86,10 @@
       end
 
       it 'test with package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = { 'com/example/' => 70 }
 
         @my_plugin.report path_a
 
@@ -98,11 +97,10 @@
       end
 
       it 'test with bigger overlapped package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 70,
           'com/' => 90
         }
@@ -113,11 +111,10 @@
       end
 
       it 'test with lower overlapped package coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 77,
           'com/' => 30
         }
@@ -128,11 +125,10 @@
       end
 
       it 'test with overlapped package coverage and bigger class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 77,
           'com/' => 30
         }
@@ -144,11 +140,10 @@
       end
 
       it 'test with overlapped package coverage and lower class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = {
           'com/example/' => 90,
           'com/' => 85
         }
@@ -157,26 +152,55 @@
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 80% | :warning: |')
       end
 
+      it 'checks modified files when "only_check_new_files" attribute is false' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.only_check_new_files = false
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 0% | :white_check_mark: |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 0% | :white_check_mark: |')
+      end
+
       it 'defaults "only_check_new_files" attribute to false' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 50
 
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 0% | :white_check_mark: |')
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 0% | :white_check_mark: |')
       end
 
+      it 'does _not_ check modified files when "only_check_new_files" attribute is true' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_c.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_class_coverage_percentage = 70
+        @my_plugin.only_check_new_files = true
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `io/sample/UseCase` | 66% | 70% | :warning: |')
+        expect(@dangerfile.status_report[:markdowns][0].message).not_to include('com/example/CachedRepository')
+      end
+
       it 'adds a link to report' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
         @my_plugin.report(path_a, 'http://test.com/')
 
@@ -184,51 +208,46 @@
       end
 
       it 'When option "fail_no_coverage_data_found" is set to optionally fail, it doesn\'t fail the execution' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
         expect { @my_plugin.report(path_a, fail_no_coverage_data_found: true) }.to_not raise_error(RuntimeError)
       end
 
       it 'When option "fail_no_coverage_data_found" is not set, the execution fails on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
         expect { @my_plugin.report path_a }.to raise_error(RuntimeError)
       end
 
       it 'When option "fail_no_coverage_data_found" is set to optionally fail, the execution fails on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
         expect { @my_plugin.report path_a, fail_no_coverage_data_found: true }.to raise_error(RuntimeError)
       end
 
       it 'When option "fail_no_coverage_data_found" is set to optionally warn (not fail), the execution doesn\'t fail on empty data' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
         expect { @my_plugin.report path_a, fail_no_coverage_data_found: false }.to_not raise_error(RuntimeError)
       end
 
       it 'prints default success subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 40
 
         @my_plugin.report path_a
 
@@ -241,11 +260,10 @@
       end
 
       it 'prints default failure subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
 
         @my_plugin.report path_a
 
@@ -258,11 +276,10 @@
       end
 
       it 'prints custom success subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 40
         @my_plugin.subtitle_success = 'You rock! 🔥'
 
         @my_plugin.report path_a
@@ -276,11 +293,10 @@
       end
 
       it 'prints custom failure subtitle' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.subtitle_failure = 'Too bad :('
 
         @my_plugin.report path_a
@@ -294,54 +310,48 @@
       end
 
       it 'prints default class column title' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
-
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
       end
 
       it 'prints custom class column title' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.class_column_title = 'New files'
 
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| New files | Covered | Required | Status |')
       end
 
       it 'instruction coverage takes over all the rest coverages for classes' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_d.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 71% | 50% | :white_check_mark: |')
       end
 
       it 'branch coverage takes over line coverage for classes, when instruction coverage is not available' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_e.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 42% | 50% | :warning: |')
       end
 
       it 'line coverage takes over for classes, when both instruction coverage and branch coverage are not available' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_f.xml"
 
-        @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
         @my_plugin.minimum_class_coverage_percentage = 50
 
         @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 93% | 50% | :white_check_mark: |')
@@ -354,11 +364,10 @@
         end
 
         it 'applies minimum_composable_class_coverage_percentage' do
           path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-          @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 
           @my_plugin.report path_a
 
@@ -373,10 +382,9 @@
         end
 
         it 'does not apply minimum_composable_class_coverage_percentage' do
           path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-          @my_plugin.files_to_check = ['src/java/com/example/CachedRepository.java', 'src/java/io/sample/UseCase.java']
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 
           @my_plugin.report path_a
 