lib/gitlab_reviewbot/strategies/strategy.rb in danger-gitlab_reviewbot-1.1.0 vs lib/gitlab_reviewbot/strategies/strategy.rb in danger-gitlab_reviewbot-1.1.1
- old
+ new
@@ -5,15 +5,14 @@
attr_accessor :project_id
attr_accessor :group_name
attr_accessor :client
attr_accessor :excluded_users
- def initialize(client:, project:, mr:, group:)
+ def initialize(client:, project:, mr:)
@client = client
@project_id = project
@mr_iid = mr
- @group_name = group
@excluded_users = []
end
def assign!(amount)
currently_assigned = fetch_assigned_reviewers()
@@ -37,12 +36,13 @@
def fetch_assigned_reviewers
client.fetch_mr_reviewers(@project_id, @mr_iid)
end
def fetch_users_in_group
- excluded_users = @excluded_users.map { |u| client.find_user_with_username(u) }
- client.fetch_users_for_group(@group_name).filter { |u| ! excluded_users.include? u }
+ excluded = @excluded_users.map { |u| client.find_user_with_username(u) }
+ client.fetch_users_for_group(@group_name).filter { |u| ! excluded.include? u }
end
+
end
end
end