spec/field_spec.rb in csvlint-1.0.0 vs spec/field_spec.rb in csvlint-1.1.0

- old
+ new

@@ -1,252 +1,247 @@ -require 'spec_helper' +require "spec_helper" describe Csvlint::Field do - it "should validate required fields" do - field = Csvlint::Field.new("test", { "required" => true } ) - expect( field.validate_column( nil ) ).to be(false) - expect( field.errors.first.category ).to be(:schema) - expect( field.validate_column( "" ) ).to be(false) - expect( field.validate_column( "data" ) ).to be(true) + field = Csvlint::Field.new("test", {"required" => true}) + expect(field.validate_column(nil)).to be(false) + expect(field.errors.first.category).to be(:schema) + expect(field.validate_column("")).to be(false) + expect(field.validate_column("data")).to be(true) end it "should include the failed constraints" do - field = Csvlint::Field.new("test", { "required" => true } ) - expect( field.validate_column( nil ) ).to be(false) - expect( field.errors.first.constraints ).to eql( { "required" => true } ) + field = Csvlint::Field.new("test", {"required" => true}) + expect(field.validate_column(nil)).to be(false) + expect(field.errors.first.constraints).to eql({"required" => true}) end it "should validate minimum length" do - field = Csvlint::Field.new("test", { "minLength" => 3 } ) - expect( field.validate_column( nil ) ).to be(false) - expect( field.validate_column( "" ) ).to be(false) - expect( field.validate_column( "ab" ) ).to be(false) - expect( field.validate_column( "abc" ) ).to be(true) - expect( field.validate_column( "abcd" ) ).to be(true) + field = Csvlint::Field.new("test", {"minLength" => 3}) + expect(field.validate_column(nil)).to be(false) + expect(field.validate_column("")).to be(false) + expect(field.validate_column("ab")).to be(false) + expect(field.validate_column("abc")).to be(true) + expect(field.validate_column("abcd")).to be(true) end it "should validate maximum length" do - field = Csvlint::Field.new("test", { "maxLength" => 3 } ) - expect( field.validate_column( nil ) ).to be(true) - expect( field.validate_column( "" ) ).to be(true) - expect( field.validate_column( "ab" ) ).to be(true) - expect( field.validate_column( "abc" ) ).to be(true) - expect( field.validate_column( "abcd" ) ).to be(false) + field = Csvlint::Field.new("test", {"maxLength" => 3}) + expect(field.validate_column(nil)).to be(true) + expect(field.validate_column("")).to be(true) + expect(field.validate_column("ab")).to be(true) + expect(field.validate_column("abc")).to be(true) + expect(field.validate_column("abcd")).to be(false) end it "should validate against regex" do - field = Csvlint::Field.new("test", { "pattern" => "\{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\}"} ) - expect( field.validate_column( "abc") ).to be(false) - expect( field.validate_column( "{3B0DA29C-C89A-4FAA-918A-0000074FA0E0}") ).to be(true) + field = Csvlint::Field.new("test", {"pattern" => "{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}}"}) + expect(field.validate_column("abc")).to be(false) + expect(field.validate_column("{3B0DA29C-C89A-4FAA-918A-0000074FA0E0}")).to be(true) end it "should apply combinations of constraints" do - field = Csvlint::Field.new("test", { "required"=>true, "pattern" => "\{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\}"} ) - expect( field.validate_column( "abc") ).to be(false) - expect( field.errors.first.constraints ).to eql( { "pattern" => "\{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\}" } ) + field = Csvlint::Field.new("test", {"required" => true, "pattern" => "{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}}"}) + expect(field.validate_column("abc")).to be(false) + expect(field.errors.first.constraints).to eql({"pattern" => "{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}}"}) - expect( field.validate_column( nil ) ).to be(false) - expect( field.errors.first.constraints ).to eql( { "required"=>true } ) + expect(field.validate_column(nil)).to be(false) + expect(field.errors.first.constraints).to eql({"required" => true}) - expect( field.validate_column( "{3B0DA29C-C89A-4FAA-918A-0000074FA0E0}") ).to be(true) - + expect(field.validate_column("{3B0DA29C-C89A-4FAA-918A-0000074FA0E0}")).to be(true) end it "should enforce uniqueness for a column" do - field = Csvlint::Field.new("test", { "unique" => true } ) - expect( field.validate_column( "abc") ).to be(true) - expect( field.validate_column( "abc") ).to be(false) - expect( field.errors.first.category ).to be(:schema) - expect( field.errors.first.type ).to be(:unique) + field = Csvlint::Field.new("test", {"unique" => true}) + expect(field.validate_column("abc")).to be(true) + expect(field.validate_column("abc")).to be(false) + expect(field.errors.first.category).to be(:schema) + expect(field.errors.first.type).to be(:unique) end context "it should validate correct types" do it "skips empty fields" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#int" }) - expect( field.validate_column("")).to be(true) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#int"}) + expect(field.validate_column("")).to be(true) end it "validates strings" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#string" }) - expect( field.validate_column("42")).to be(true) - expect( field.validate_column("forty-two")).to be(true) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#string"}) + expect(field.validate_column("42")).to be(true) + expect(field.validate_column("forty-two")).to be(true) end it "validates ints" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#int" }) - expect( field.validate_column("42")).to be(true) - expect( field.validate_column("forty-two")).to be(false) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#int"}) + expect(field.validate_column("42")).to be(true) + expect(field.validate_column("forty-two")).to be(false) end it "validates integers" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#integer" }) - expect( field.validate_column("42")).to be(true) - expect( field.validate_column("forty-two")).to be(false) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#integer"}) + expect(field.validate_column("42")).to be(true) + expect(field.validate_column("forty-two")).to be(false) end it "validates floats" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#float" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#float"}) expect(field.validate_column("42.0")).to be(true) expect(field.validate_column("42")).to be(true) expect(field.validate_column("forty-two")).to be(false) end it "validates URIs" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#anyURI" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#anyURI"}) expect(field.validate_column("http://theodi.org/team")).to be(true) expect(field.validate_column("https://theodi.org/team")).to be(true) expect(field.validate_column("42.0")).to be(false) end it "works with invalid URIs" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#anyURI" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#anyURI"}) expect(field.validate_column("£123")).to be(false) end it "validates booleans" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#boolean" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#boolean"}) expect(field.validate_column("true")).to be(true) expect(field.validate_column("1")).to be(true) expect(field.validate_column("false")).to be(true) expect(field.validate_column("0")).to be(true) expect(field.validate_column("derp")).to be(false) end context "it should validate all kinds of integers" do it "validates a non-positive integer" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#nonPositiveInteger" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#nonPositiveInteger"}) expect(field.validate_column("0")).to be(true) expect(field.validate_column("-1")).to be(true) expect(field.validate_column("1")).to be(false) end it "validates a negative integer" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#negativeInteger" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#negativeInteger"}) expect(field.validate_column("0")).to be(false) expect(field.validate_column("-1")).to be(true) expect(field.validate_column("1")).to be(false) end it "validates a non-negative integer" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#nonNegativeInteger" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#nonNegativeInteger"}) expect(field.validate_column("0")).to be(true) expect(field.validate_column("-1")).to be(false) expect(field.validate_column("1")).to be(true) end it "validates a positive integer" do - field = Csvlint::Field.new("test", { "type" => "http://www.w3.org/2001/XMLSchema#positiveInteger" }) + field = Csvlint::Field.new("test", {"type" => "http://www.w3.org/2001/XMLSchema#positiveInteger"}) expect(field.validate_column("0")).to be(false) expect(field.validate_column("-1")).to be(false) - expect(field.errors.first.constraints).to eql( { "type" => "http://www.w3.org/2001/XMLSchema#positiveInteger" } ) + expect(field.errors.first.constraints).to eql({"type" => "http://www.w3.org/2001/XMLSchema#positiveInteger"}) expect(field.validate_column("1")).to be(true) end end context "when validating ranges" do - it "should enforce minimum values" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#int", - "minimum" => "40" + "type" => "http://www.w3.org/2001/XMLSchema#int", + "minimum" => "40" }) - expect( field.validate_column("42")).to be(true) + expect(field.validate_column("42")).to be(true) field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#int", - "minimum" => "40" + "type" => "http://www.w3.org/2001/XMLSchema#int", + "minimum" => "40" }) - expect( field.validate_column("39")).to be(false) - expect( field.errors.first.type ).to eql(:below_minimum) + expect(field.validate_column("39")).to be(false) + expect(field.errors.first.type).to eql(:below_minimum) end it "should enforce maximum values" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#int", - "maximum" => "40" + "type" => "http://www.w3.org/2001/XMLSchema#int", + "maximum" => "40" }) - expect( field.validate_column("39")).to be(true) + expect(field.validate_column("39")).to be(true) field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#int", - "maximum" => "40" + "type" => "http://www.w3.org/2001/XMLSchema#int", + "maximum" => "40" }) - expect( field.validate_column("41")).to be(false) - expect( field.errors.first.type ).to eql(:above_maximum) - + expect(field.validate_column("41")).to be(false) + expect(field.errors.first.type).to eql(:above_maximum) end end context "when validating dates" do it "should validate a date time" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#dateTime" - }) - expect( field.validate_column("2014-02-17T11:09:00Z")).to be(true) - expect( field.validate_column("invalid-date")).to be(false) - expect( field.validate_column("2014-02-17")).to be(false) + "type" => "http://www.w3.org/2001/XMLSchema#dateTime" + }) + expect(field.validate_column("2014-02-17T11:09:00Z")).to be(true) + expect(field.validate_column("invalid-date")).to be(false) + expect(field.validate_column("2014-02-17")).to be(false) end it "should validate a date" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#date" - }) - expect( field.validate_column("2014-02-17T11:09:00Z")).to be(false) - expect( field.validate_column("invalid-date")).to be(false) - expect( field.validate_column("2014-02-17")).to be(true) + "type" => "http://www.w3.org/2001/XMLSchema#date" + }) + expect(field.validate_column("2014-02-17T11:09:00Z")).to be(false) + expect(field.validate_column("invalid-date")).to be(false) + expect(field.validate_column("2014-02-17")).to be(true) end it "should validate a time" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#time" - }) - expect( field.validate_column("11:09:00")).to be(true) - expect( field.validate_column("2014-02-17T11:09:00Z")).to be(false) - expect( field.validate_column("not-a-time")).to be(false) - expect( field.validate_column("27:97:00")).to be(false) + "type" => "http://www.w3.org/2001/XMLSchema#time" + }) + expect(field.validate_column("11:09:00")).to be(true) + expect(field.validate_column("2014-02-17T11:09:00Z")).to be(false) + expect(field.validate_column("not-a-time")).to be(false) + expect(field.validate_column("27:97:00")).to be(false) end it "should validate a year" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#gYear" - }) - expect( field.validate_column("1999")).to be(true) - expect( field.validate_column("2525")).to be(true) - expect( field.validate_column("0001")).to be(true) - expect( field.validate_column("2014-02-17T11:09:00Z")).to be(false) - expect( field.validate_column("not-a-time")).to be(false) - expect( field.validate_column("27:97:00")).to be(false) + "type" => "http://www.w3.org/2001/XMLSchema#gYear" + }) + expect(field.validate_column("1999")).to be(true) + expect(field.validate_column("2525")).to be(true) + expect(field.validate_column("0001")).to be(true) + expect(field.validate_column("2014-02-17T11:09:00Z")).to be(false) + expect(field.validate_column("not-a-time")).to be(false) + expect(field.validate_column("27:97:00")).to be(false) end it "should validate a year-month" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#gYearMonth" - }) - expect( field.validate_column("1999-12")).to be(true) - expect( field.validate_column("2525-01")).to be(true) - expect( field.validate_column("2014-02-17T11:09:00Z")).to be(false) - expect( field.validate_column("not-a-time")).to be(false) - expect( field.validate_column("27:97:00")).to be(false) + "type" => "http://www.w3.org/2001/XMLSchema#gYearMonth" + }) + expect(field.validate_column("1999-12")).to be(true) + expect(field.validate_column("2525-01")).to be(true) + expect(field.validate_column("2014-02-17T11:09:00Z")).to be(false) + expect(field.validate_column("not-a-time")).to be(false) + expect(field.validate_column("27:97:00")).to be(false) end it "should allow user to specify custom date time pattern" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#dateTime", - "datePattern" => "%Y-%m-%d %H:%M:%S" - }) - expect( field.validate_column("1999-12-01 10:00:00")).to be(true) - expect( field.validate_column("invalid-date")).to be(false) - expect( field.validate_column("2014-02-17")).to be(false) - expect( field.errors.first.constraints ).to eql( { - "type" => "http://www.w3.org/2001/XMLSchema#dateTime", - "datePattern" => "%Y-%m-%d %H:%M:%S" - }) - + "type" => "http://www.w3.org/2001/XMLSchema#dateTime", + "datePattern" => "%Y-%m-%d %H:%M:%S" + }) + expect(field.validate_column("1999-12-01 10:00:00")).to be(true) + expect(field.validate_column("invalid-date")).to be(false) + expect(field.validate_column("2014-02-17")).to be(false) + expect(field.errors.first.constraints).to eql({ + "type" => "http://www.w3.org/2001/XMLSchema#dateTime", + "datePattern" => "%Y-%m-%d %H:%M:%S" + }) end it "should allow user to compare dates" do field = Csvlint::Field.new("test", { - "type" => "http://www.w3.org/2001/XMLSchema#dateTime", - "datePattern" => "%Y-%m-%d %H:%M:%S", - "minimum" => "1990-01-01 10:00:00" - }) - expect( field.validate_column("1999-12-01 10:00:00")).to be(true) - expect( field.validate_column("1989-12-01 10:00:00")).to be(false) + "type" => "http://www.w3.org/2001/XMLSchema#dateTime", + "datePattern" => "%Y-%m-%d %H:%M:%S", + "minimum" => "1990-01-01 10:00:00" + }) + expect(field.validate_column("1999-12-01 10:00:00")).to be(true) + expect(field.validate_column("1989-12-01 10:00:00")).to be(false) end end end end