spec/lib/credy/rules_spec.rb in credy-0.1.1 vs spec/lib/credy/rules_spec.rb in credy-0.2.0

@@ -2,124 +2,93 @@
 
 describe Credy::Rules do
 
   subject { Credy::Rules }
 
-  describe '.all' do
-
-    it { should respond_to :all }
-    its(:all) { should be_a Hash }
-
-    it 'should be tested more'
-
+  describe '.raw' do
+    it { should respond_to :raw }
+    its(:raw) { should be_a Hash }
   end
 
-  describe '.flatten' do
+  describe '.all' do
 
-    it { should respond_to :flatten }
-    its(:flatten) { should be_a Array }
+    its(:all) { should be_a Array }
 
-    it 'flattens a rules hash' do
-      subject.stub(:all).and_return({
+    it 'contains a set of rules' do
+      subject.stub(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
             'ch' => '404159',
             'au' => '401795'
           }
         },
         'mastercard' => {
           'length' => 16,
-          'countries' => {
-            'us' => '504837'
-          }
-        },
+          'prefix' => '51'
+        }
       })
 
-      subject.flatten.should == [
-        {:prefix=>"404159", :length=>[13, 16], :type=>"visa", :country=>"ch"},
-        {:prefix=>"401795", :length=>[13, 16], :type=>"visa", :country=>"au"},
-        {:prefix=>"504837", :length=>16, :type=>"mastercard", :country=>"us"}
+      expect(subject.all).to eq [
+        {prefix:"404159", length:[13, 16], type:"visa", country:"ch"},
+        {prefix:"401795", length:[13, 16], type:"visa", country:"au"},
+        {prefix:"51", length:16, type:"mastercard"}
       ]
     end
 
     it 'works with string prefixes' do
-      subject.stub(:all).and_return({
+      subject.stub(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
             'au' => '401795'
           }
         }
       })
 
-      subject.flatten.should == [
-        {:prefix=>"401795", :length=>[13, 16], :type=>"visa", :country=>"au"}
+      expect(subject.all).to eq [
+        {prefix:"401795", length:[13, 16], type:"visa", country:"au"}
       ]
     end
 
     it 'works with integer prefixes' do
-      subject.stub(:all).and_return({
+      subject.stub(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
             'au' => 401795
           }
         }
       })
 
-      subject.flatten.should == [
-        {:prefix=>"401795", :length=>[13, 16], :type=>"visa", :country=>"au"}
+      expect(subject.all).to eq [
+        {prefix:"401795", length:[13, 16], type:"visa", country:"au"}
       ]
     end
 
     it 'works with an array of prefixes' do
-      subject.stub(:all).and_return({
+      subject.stub(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
             'au' => ['401795', '404137']
           }
         }
       })
 
-      subject.flatten.should == [
-        {:prefix=>"401795", :length=>[13, 16], :type=>"visa", :country=>"au"},
-        {:prefix=>"404137", :length=>[13, 16], :type=>"visa", :country=>"au"}
+      expect(subject.all).to eq [
+        {prefix:"401795", length:[13, 16], type:"visa", country:"au"},
+        {prefix:"404137", length:[13, 16], type:"visa", country:"au"}
       ]
     end
 
-    it 'includes global rules' do
-      subject.stub(:all).and_return({
-        'visa' => {
-          'length' => [13, 16],
-          'prefix' => '4',
-          'countries' => {
-            'ch' => '404159',
-            'au' => '401'
-          }
-        },
-        'mastercard' => {
-          'length' => 16,
-          'prefix' => '51'
-        },
-      })
-
-      subject.flatten(true).should == [
-        {:prefix=>"404159", :length=>[13, 16], :type=>"visa", :country=>"ch"},
-        {:prefix=>"401", :length=>[13, 16], :type=>"visa", :country=>"au"},
-        {:prefix=>"51", :length=>16, :type=>"mastercard"},
-        {:prefix=>"4", :length=>[13, 16], :type=>"visa"}
-      ]
-    end
-
   end
 
-  describe '.filter' do 
+  describe '.filter' do
 
-    before do 
-      subject.stub(:all).and_return({
+    before do
+      subject.stub(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
             'ch' => '404159',
             'au' => '401795'
@@ -135,33 +104,33 @@
     end
 
     it { should respond_to :filter }
 
     it 'returns everything if no filter is provided' do
-      subject.filter.should be_a Array
-      subject.filter.should == subject.flatten
+      expect(subject.filter).to be_a Array
+      expect(subject.filter).to eq subject.all
     end
 
     it 'filters by type' do
-      subject.filter(type: 'visa').length.should == 2
-      subject.filter(type: 'mastercard').length.should == 1
+      expect(subject.filter(type: 'visa')).to have(2).items
+      expect(subject.filter(type: 'mastercard')).to have(1).item
     end
 
     it 'accepts the :country option' do
-      subject.filter(country: 'ch').length.should == 1
-      subject.filter(country: 'au').length.should == 2
+      expect(subject.filter(country: 'ch')).to have(1).item
+      expect(subject.filter(country: 'au')).to have(2).items
     end
 
     it 'accepts several options at the same time' do
       rules = subject.filter type: 'visa', country: 'au'
-      rules.length.should == 1
+      expect(rules).to have(1).item
     end
 
     it 'returns an empty array if nothing is found' do
       rules = subject.filter type: 'foo', country: 'bar'
-      rules.should be_a Array
-      rules.should be_empty
+      expect(rules).to be_a Array
+      expect(rules).to be_empty
     end
 
   end
 
-end
\ No newline at end of file
+end