cookstyle.yml in cookstyle-7.32.7

- old
+ new

@@ -1,7 +1,9 @@
 AllCops:
   SuggestExtensions: false
+  NewCops: disable
+  DisabledByDefault: true
   TargetRubyVersion: 2.5
   TargetChefVersion: ~
   inherit_mode:
     merge:
      - Include
@@ -2369,14 +2371,14 @@
 
 #### The base rubocop 0.37 enabled.yml file we started with ####
 
 Layout/AccessModifierIndentation:
   Enabled: true
-Layout/AlignArray:
-  Enabled: true
-Layout/AlignHash:
-  Enabled: true
+# Layout/AlignArray: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
+# Layout/AlignHash: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Style/AndOr:
   Enabled: true
 Style/ArrayJoin:
   Enabled: true
 Naming/AsciiIdentifiers:
@@ -2391,12 +2393,10 @@
   Enabled: true
 Layout/BlockEndNewline:
   Enabled: true
 Style/BlockDelimiters:
   Enabled: true
-Style/BracesAroundHashParameters:
-  Enabled: true
 Style/CaseEquality:
   Enabled: true
 Layout/CaseIndentation:
   Enabled: true
 Style/CharacterLiteral:
@@ -2423,12 +2423,12 @@
   Enabled: true
 Naming/ConstantName:
   Enabled: true
 Style/DefWithParentheses:
   Enabled: true
-Style/DeprecatedHashMethods:
-  Enabled: true
+# Style/DeprecatedHashMethods: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Layout/DotPosition:
   Enabled: true
 Style/EachWithObject:
   Enabled: true
 Layout/ElseAlignment:
@@ -2480,28 +2480,28 @@
   Enabled: true
 Layout/IndentationWidth:
   Enabled: true
 Style/IdenticalConditionalBranches:
   Enabled: true
-Layout/IndentArray:
-  Enabled: true
-Layout/IndentAssignment:
-  Enabled: true
-Layout/IndentHash:
-  Enabled: true
+# Layout/IndentArray: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
+# Layout/IndentAssignment: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
+# Layout/IndentHash: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Style/InfiniteLoop:
   Enabled: true
 Style/Lambda:
   Enabled: true
 Style/LambdaCall:
   Enabled: true
 Layout/LeadingCommentSpace:
   Enabled: true
 Style/LineEndConcatenation:
   Enabled: true
-Style/MethodCallParentheses:
-  Enabled: true
+# Style/MethodCallParentheses: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Style/MethodDefParentheses:
   Enabled: true
 Style/MultilineBlockChain:
   Enabled: true
 Layout/MultilineBlockLayout:
@@ -2534,12 +2534,12 @@
   Enabled: true
 Style/Not:
   Enabled: true
 Style/OneLineConditional:
   Enabled: true
-Naming/OpMethod:
-  Enabled: true
+# Naming/OpMethod: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Style/OptionalArguments:
   Enabled: true
 Style/ParallelAssignment:
   Enabled: true
 Style/ParenthesesAroundCondition:
@@ -2639,16 +2639,16 @@
   Enabled: true
 Style/TrivialAccessors:
   Enabled: true
 Style/UnlessElse:
   Enabled: true
-Style/UnneededCapitalW:
-  Enabled: true
-Style/UnneededInterpolation:
-  Enabled: true
-Style/UnneededPercentQ:
-  Enabled: true
+# Style/UnneededCapitalW: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
+# Style/UnneededInterpolation: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
+# Style/UnneededPercentQ: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Style/TrailingUnderscoreVariable:
   Enabled: true
 Style/VariableInterpolation:
   Enabled: true
 Style/WhenThen:
@@ -2678,12 +2678,12 @@
   Enabled: true
 Lint/DeprecatedClassMethods:
   Enabled: true
 Lint/DuplicateMethods:
   Enabled: true
-Lint/DuplicatedKey:
-  Enabled: true
+# Lint/DuplicatedKey: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Lint/EachWithObjectArgument:
   Enabled: true
 Lint/ElseLayout:
   Enabled: true
 Lint/EmptyEnsure:
@@ -2691,22 +2691,22 @@
 Lint/EmptyInterpolation:
   Enabled: true
 Layout/EndAlignment:
   Enabled: true
   AutoCorrect: true
-Lint/EndInMethod:
-  Enabled: true
+# Lint/EndInMethod: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Lint/EnsureReturn:
   Enabled: true
 Security/Eval:
   Enabled: true
 Lint/FloatOutOfRange:
   Enabled: true
 Lint/FormatParameterMismatch:
   Enabled: true
-Lint/HandleExceptions:
-  Enabled: true
+# Lint/HandleExceptions: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Lint/ImplicitStringConcatenation:
   Enabled: true
   Exclude:
     - '**/metadata.rb' # this prevents conflicts with Chef/Correctness/MetadataMalformedDepends
 Lint/IneffectiveAccessModifier:
@@ -2731,28 +2731,28 @@
   Enabled: true
 Lint/RescueException:
   Enabled: true
 Lint/ShadowingOuterLocalVariable:
   Enabled: true
-Lint/StringConversionInInterpolation:
-  Enabled: true
+# Lint/StringConversionInInterpolation: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
-Lint/UnneededCopDisableDirective:
-  Enabled: true
+# Lint/UnneededCopDisableDirective: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Lint/UnusedBlockArgument:
   Enabled: true
 Lint/UnusedMethodArgument:
   Enabled: true
 Lint/UnreachableCode:
   Enabled: true
 Lint/UselessAccessModifier:
   Enabled: true
 Lint/UselessAssignment:
   Enabled: true
-Lint/UselessComparison:
-  Enabled: true
+# Lint/UselessComparison: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 Lint/UselessElseWithoutRescue:
   Enabled: true
 Lint/UselessSetterCall:
   Enabled: true
 Lint/Void:
@@ -2865,12 +2865,12 @@
 # There's no reason to have a gem listed twice
 Bundler/DuplicatedGem:
   Enabled: true
 
 # This results in very confusing code to read with little perf benefit
-Performance/Casecmp:
-  Enabled: false
+# Performance/Casecmp: # TODO: move to cookstyle project .rubocop.yml?
+#   Enabled: false
 
 # This comes with changing the ruby target to 2.3+
 Style/FrozenStringLiteralComment:
   Enabled: false
 
@@ -2924,32 +2924,32 @@
 
 # Avoid ruby deprecation warnings
 Lint/UriRegexp:
   Enabled: true
 
-Performance/UriDefaultParser:
-  Enabled: true
+# Performance/UriDefaultParser: # TODO: move to cookstyle project .rubocop.yml?
+#   Enabled: true
 
 # :true or :false seems like a horrible idea
 Lint/BooleanSymbol:
   Enabled: true
 
 # this avoids very verbose code for no reason
 Style/RedundantConditional:
   Enabled: true
 
 # catches people writing a regex check wrong
-Lint/RegexpInCondition:
-  Enabled: true
+# Lint/RegexpInCondition: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 
 # Avoids pointless / complex code
 Lint/RedundantWithObject:
   Enabled: true
 
 # avoid requiring things that come for free
-Lint/UnneededRequireStatement:
-  Enabled: true
+# Lint/UnneededRequireStatement: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 
 # Avoid poorly formatted methods
 Style/TrailingBodyOnMethodDefinition:
   Enabled: true
 
@@ -2968,11 +2968,11 @@
 # warn on deprecated functionality
 Lint/BigDecimalNew:
   Enabled: true
 
 # remove bogus rubocop comments. We already enabled Disable directives
-Lint/UnneededCopEnableDirective:
-  Enabled: true
+# Lint/UnneededCopEnableDirective: TODO broken with rubocop 1.25.1 move
+#   Enabled: true
 
 # get people on a much simpler ruby 2.4+ way of doing things
 Style/UnpackFirst:
   Enabled: true
 