lib/coder_wally/api.rb in coder_wally-0.1.0 vs lib/coder_wally/api.rb in coder_wally-0.1.1

@@ -9,59 +9,59 @@
       uri = uri_for_user(username)
       json = send_request(uri)
 
       begin
         JSON.parse(json.read)
-      rescue JSON::ParserError => error
+      rescue JSON::ParserError
         raise InvalidJson, 'Received invalid json in response'
       end
     end
 
     private
-      # Dispatch the request
-      def send_request(url)
-        begin
-          open(url)
-        rescue OpenURI::HTTPError => error
-          handle_user_not_found_error(error)
-          handle_server_error(error)
-        end
-      end
 
-      # Parse status code from error
-      def get_status_code(error)
-        error.io.status[0]
-      end
+    # Dispatch the request
+    def send_request(url)
+      open(url)
+    rescue OpenURI::HTTPError => error
+      handle_user_not_found_error(error)
+      handle_server_error(error)
+    end
 
-      # Raise server error
-      def handle_server_error(error)
-        raise ServerError, 'Server error' if  get_status_code(error) == '500'
-      end
+    # Parse status code from error
+    def get_status_code(error)
+      error.io.status[0]
+    end
 
-      # Raise user not found error
-      def handle_user_not_found_error(error)
-        raise UserNotFoundError, 'User not found' if  get_status_code(error) == '404'
-      end
+    # Raise server error
+    def handle_server_error(error)
+      fail ServerError, 'Server error' if get_status_code(error) == '500'
+    end
 
-      # Build user URI from username and api url
-      def uri_for_user(username)
-        raise(ArgumentError, 'Please provide a username') if username.empty?
+    # Raise user not found error
+    def handle_user_not_found_error(error)
+      fail UserNotFoundError, 'User not found' if get_status_code(error) == '404'
+    end
 
-        URI.parse(api_url % username)
-      end
+    # Build user URI from username and api url
+    def uri_for_user(username)
+      fail ArgumentError, 'Please provide a username' if username.empty?
 
-      # The URL of the API we'll use.
-      def api_url
-        'https://coderwall.com/%s.json'
-      end
+      URI.parse(api_url % username)
+    end
+
+    # The URL of the API we'll use.
+    def api_url
+      'https://coderwall.com/%s.json'
+    end
   end
 end
+
 # Handles user not found exception
 class UserNotFoundError < StandardError
 end
 
 # Handles server exception
 class ServerError < StandardError
 end
 # Handles bad JSON
 class InvalidJson < StandardError
-end
\ No newline at end of file
+end