app/controllers/cms9/posts_controller.rb in cms9-0.2.0 vs app/controllers/cms9/posts_controller.rb in cms9-0.2.1

@@ -1,13 +1,14 @@
 module Cms9
+  # posts controller
   class PostsController < Cms9::ApplicationController
     def index
       @post_definition = Cms9::PostDefinition.find(params[:post_definition_id])
       @posts = Post.where(post_definition: @post_definition)
-                  .order('created_at desc')
-                  .page(params[:page])
-                  .per(20)
+                   .order('created_at desc')
+                   .page(params[:page])
+                   .per(20)
     end
 
     def new
       @post = Post.new
       @post.post_definition_id = params[:post_definition_id]
@@ -17,15 +18,14 @@
       end
     end
 
     def create
       @post = Post.new(post_params)
-
       @post.user_id = current_user.id
 
       if @post.save
-        Cms9Events.new.create_event('post', @post.id, params[:action], current_user, nil)
+        create_post_event(@post.id, nil)
         redirect_to posts_path(post_definition_id: @post.post_definition.id)
       else
         render :new
       end
     end
@@ -40,37 +40,45 @@
       end
     end
 
     def update
       @post = Post.find(params[:id])
-
       @post.user_id = current_user.id
 
       if @post.update(post_params)
-        Cms9Events.new.create_event('post', @post.id, params[:action], current_user, nil)
+        create_post_event(@post.id, nil)
         redirect_to posts_path(post_definition_id: @post.post_definition.id)
       else
         render :edit
       end
     end
 
     def destroy
       @post = Post.find(params[:id])
       post_definition_id = @post.post_definition.id
 
-      post_name = Field.where(post_field_id: @post.post_definition.post_fields[0].id, post_id: @post.id)[0]
-      Cms9Events.new.create_event('post', @post.id, params[:action], current_user, post_name)
-
-      @post.destroy
-
+      create_post_event(@post.id, post_name) && @post.destroy
       redirect_to posts_path(post_definition_id: post_definition_id)
     end
 
     private
-      def post_params
-        params.require(:post).permit(:post_definition_id, fields_attributes:
-                                    [:id, :post_id, :post_field_id, :value, { :value => [] },
-                                     :image, :image_uid, :image_name, :remove_image, :image_custom_size])
-      end
 
+    def post_name
+      Field.where(post_field_id: @post.post_definition
+                                      .post_fields[0].id,
+                  post_id: @post.id)[0]['value']
+    end
+
+    def create_post_event(post_id, post_name)
+      Cms9Events.new.create_event('post', post_id, params[:action],
+                                  current_user, post_name)
+    end
+
+    def post_params
+      params.require(:post).permit(:post_definition_id, fields_attributes:
+                                  [:id, :post_id, :post_field_id, :value,
+                                   { value: [] },
+                                   :image, :image_uid, :image_name,
+                                   :remove_image, :image_custom_size])
+    end
   end
 end