config/chefstyle.yml in chefstyle-0.12.0 vs config/chefstyle.yml in chefstyle-0.13.0

- old
+ new

@@ -4,11 +4,11 @@ # # Bundler # Bundler/DuplicatedGem: - Enabled: true + Enabled: false # # Lint # @@ -64,12 +64,10 @@ Enabled: true Lint/InheritException: Enabled: true Lint/IneffectiveAccessModifier: Enabled: true -Lint/InvalidCharacterLiteral: - Enabled: true Lint/LiteralInCondition: Enabled: true Lint/LiteralInInterpolation: Enabled: true Lint/Loop: @@ -102,12 +100,10 @@ Enabled: true Lint/UnderscorePrefixedVariableName: Enabled: true Lint/UnifiedInteger: Enabled: true -Lint/UnneededDisable: - Enabled: true Lint/UnneededSplatExpansion: Enabled: true Lint/UnreachableCode: Enabled: true Lint/UselessAccessModifier: @@ -143,92 +139,10 @@ # disabling this will make it easier to stage chefstyle rollouts Lint/UnneededDisable: Enabled: false # -# Performance -# - -Performance/Casecmp: - Enabled: true -Performance/CaseWhenSplat: - Enabled: true -Performance/CompareWithBlock: - Enabled: true -Performance/Count: - Enabled: true -Performance/Detect: - Enabled: true -Performance/DoubleStartEndWith: - Enabled: true -Performance/EndWith: - Enabled: true -Performance/FixedSize: - Enabled: true -Performance/FlatMap: - Enabled: true -Performance/HashEachMethods: - Enabled: true -Performance/LstripRstrip: - Enabled: true -Performance/RangeInclude: - Enabled: true -Performance/RedundantBlockCall: - Enabled: true -Performance/RedundantMatch: - Enabled: true -Performance/RedundantMerge: - Enabled: true -Performance/RedundantSortBy: - Enabled: true -Performance/RegexpMatch: - Enabled: true -Performance/ReverseEach: - Enabled: true -Performance/Sample: - Enabled: true -Performance/Size: - Enabled: true -Performance/SortWithBlock: - Enabled: true -Performance/StartWith: - Enabled: true -Performance/StringReplacement: - Enabled: true -Performance/TimesMap: - Enabled: true - -# -# Rails -# - -Rails/ActionFilter: - Enabled: true -Rails/Date: - Enabled: true -Rails/Delegate: - Enabled: true -Rails/FindBy: - Enabled: true -Rails/FindEach: - Enabled: true -Rails/HasAndBelongsToMany: - Enabled: true -Rails/Output: - Enabled: true -Rails/PluralizationGrammar: - Enabled: true -Rails/ReadWriteAttribute: - Enabled: true -Rails/ScopeArgs: - Enabled: true -Rails/TimeZone: - Enabled: true -Rails/Validation: - Enabled: true - -# # Security # Security/Eval: Enabled: true @@ -317,16 +231,14 @@ EnforcedStyle: lf Style/EvenOdd: Enabled: true Layout/ExtraSpacing: Enabled: true -Style/FlipFlop: +Lint/FlipFlop: Enabled: true Style/For: Enabled: true -Style/FrozenStringLiteralComment: - Enabled: true Style/HashSyntax: Enabled: true Naming/HeredocDelimiterCase: Enabled: true Style/IfUnlessModifierOfIfUnless: @@ -382,11 +294,11 @@ Style/NumericPredicate: Enabled: true EnforcedStyle: comparison Style/OneLineConditional: Enabled: true -Style/OpMethod: +Naming/BinaryOperatorParameterName: Enabled: true Style/OptionalArguments: Enabled: true Style/ParenthesesAroundCondition: Enabled: true @@ -490,13 +402,16 @@ Enabled: true Style/TrailingCommaInHashLiteral: Enabled: true EnforcedStyleForMultiline: comma # rubocop's default gets this completely backwards -Style/TrailingCommaInLiteral: +Style/TrailingCommaInArray: Enabled: true EnforcedStyleForMultiline: comma +Style/TrailingCommaInHash: + Enabled: true + EnforcedStyleForMultiline: comma Style/TrailingUnderscoreVariable: Enabled: true Layout/TrailingWhitespace: Enabled: true Style/UnneededCapitalW: @@ -568,11 +483,11 @@ # we are ruby > 2.0 only so can disable the Encoding cop Style/Encoding: Enabled: false # Dan is -1 on this one: https://github.com/chef/chef/pull/4526#issuecomment-179950045 -Layout/IndentHash: +Layout/IndentFirstHashElement: Enabled: false # This is overly aggressive and autofix broke stuff, would need to exclude classes # - https://github.com/chef/chef/pull/4541 Style/TrivialAccessors: @@ -620,9 +535,15 @@ Enabled: false # This cop is horrible and I hate the code it produces (even though I tend to like GuardClauses in lots of cases) Style/GuardClause: Enabled: false + +Style/RedundantSortBy: + Enabled: true + +Style/Sample: + Enabled: true # Let authors order gems however makes sense Bundler/OrderedGems: Enabled: false