spec/features/users/sign_in_spec.rb in cadenero-0.0.2.b3 vs spec/features/users/sign_in_spec.rb in cadenero-0.0.2.b4

@@ -1,95 +1,61 @@
 require 'spec_helper'
 require 'cadenero/testing_support/subdomain_helpers'
+require 'cadenero/testing_support/authentication_helpers'
 
 feature 'User sign in' do
   extend Cadenero::TestingSupport::SubdomainHelpers
+  include Cadenero::TestingSupport::AuthenticationHelpers
+ 
 
-  def create_account_user
-    @user ||= { email: "[e-mail]", password: "password" }
-  end
-
-  def account_user(user)
-    @user = { email: user.email, password: "password" }
-  end
-
-  def find_account_by_email
-    create_account_user
-    @account = Cadenero::V1::Account.where(name: @user[:email]).first
-  end
-
-  def sign_in_user(url, user)
-    post "#{url}", format: :json, user: user
-    find_account_by_email
-  end
-
   let(:account) { FactoryGirl.create(:account_with_schema) }
   let(:errors_redirect_ro_sign_in) {{errors: %Q{Please sign in. posting the user json credentials as: {"user": {"email": "[e-mail]", "password": "changeme"}} to /v1/sessions}, links: "/v1/sessions"}.to_json}
   let(:errors_invalid_email_or_password)  {{ errors: {user:["Invalid email or password"]} }.to_json} 
   let(:errors_invalid_subdomain)  {{ errors: {subdomain:["Invalid subdomain"]} }.to_json} 
   let(:sessions_url) { "http://#{account.subdomain}.example.com/v1/sessions" }
   let(:error_url) { "http://error.example.com/v1/sessions" }
   let(:root_url) { "http://#{account.subdomain}.example.com/v1" }
 
   within_account_subdomain do
     scenario "signs in as an account owner successfully" do
-      get cadenero.v1_root_url(:subdomain => account.subdomain)
-      expect(last_response.body).to eql(errors_redirect_ro_sign_in)
-      expect(last_response.status).to eq 422
-      sign_in_user sessions_url, account_user(account.owner)
-      expect(last_response.status).to eq 201
-      expect(JSON.parse(last_response.body)["user"]["account_ids"]).to eq [account.id]
-      user_email = JSON.parse(last_response.body)["user"]["email"]
-      expect(JSON.parse(last_response.body)).to have_content "auth_token"
-      access_token = JSON.parse(last_response.body)["user"]["auth_token"]
-      expect(JSON.parse(last_response.body)["user"]["auth_token"]).to eq account.authentication_token
+      check_error_for_not_signed_in_yet
+      user_email = successful_sign_in_owner(account)
       get root_url
       expect(last_response.status).to eq 200
-      expect(JSON.parse(last_response.body)["message"]).to have_content user_email
+      expect(json_last_response_body["message"]).to have_content user_email
     end
 
     scenario "signout as an account owner successfully" do
-      sign_in_user sessions_url, account_user(account.owner)
-      expect(last_response.status).to eq 201
-      expect(JSON.parse(last_response.body)["user"]["account_ids"]).to eq [account.id]
-      user_email = JSON.parse(last_response.body)["user"]["email"]
+      user_email = successful_sign_in_owner(account)
       delete sessions_url, id: account.owner.id
       expect(last_response.status).to eq 200
-      expect(JSON.parse(last_response.body)["message"]).to have_content "Successful logout"
-      get cadenero.v1_root_url(:subdomain => account.subdomain)
-      expect(last_response.status).to eq 422
-      expect(last_response.body).to eql(errors_redirect_ro_sign_in)
+      expect(json_last_response_body["message"]).to have_content "Successful logout"
+      check_error_for_not_signed_in_yet
     end
 
   end
 
   it "attempts sign in with an invalid password and fails" do
-    get cadenero.v1_root_url(:subdomain => account.subdomain)
-    expect(last_response.body).to eql(errors_redirect_ro_sign_in)
+    check_error_for_not_signed_in_yet
     sign_in_user sessions_url, { email: "[e-mail]", password: "" }
-    expect(last_response.status).to eq 422
-    expect(last_response.body).to eql(errors_invalid_email_or_password)
+    expected_json_errors(errors_invalid_email_or_password)
   end
 
   it "attempts sign in with an invalid email address and fails" do
-    get cadenero.v1_root_url(:subdomain => account.subdomain)
-    expect(last_response.body).to eql(errors_redirect_ro_sign_in)
+    check_error_for_not_signed_in_yet
     sign_in_user sessions_url, { email: "[e-mail]", password: "password"}
-    expect(last_response.status).to eq 422
-    expect(last_response.body).to eql(errors_invalid_email_or_password)
+    expected_json_errors(errors_invalid_email_or_password)
   end
 
-  it "cannot sign in if not a part of an existing subdomain" do
+  it "cannot sign in if not a member of an existing subdomain" do
     other_account = FactoryGirl.create(:account)
     get cadenero.v1_root_url(:subdomain => account.subdomain)
     expect(last_response.body).to eql(errors_redirect_ro_sign_in)
     sign_in_user sessions_url, { email: other_account.owner.email, password: "" }
-    expect(last_response.status).to eq 422
-    expect(last_response.body).to eql(errors_invalid_email_or_password)
+    expected_json_errors(errors_invalid_email_or_password)
   end
 
   it "cannot sign in if the subdomain does not exist" do 
     sign_in_user error_url, account_user(account.owner)
-    expect(last_response.status).to eq 422
-    expect(last_response.body).to eql(errors_invalid_subdomain)
+    expected_json_errors(errors_invalid_subdomain)
   end   
 end
\ No newline at end of file