lib/bunq/signature.rb in bunq-client-0.7.2 vs lib/bunq/signature.rb in bunq-client-1.0.0

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 require_relative 'errors'
 
 module Bunq
   class Signature
     # headers in raw_headers hash in rest client are all lower case
     BUNQ_HEADER_PREFIX = 'X-Bunq-'.downcase
     BUNQ_SERVER_SIGNATURE_RESPONSE_HEADER = 'X-Bunq-Server-Signature'.downcase
 
     def initialize(private_key, server_public_key)
-      fail ArgumentError.new('private_key is mandatory') unless private_key
-      fail ArgumentError.new('server_public_key is mandatory') unless server_public_key
+      fail ArgumentError, 'private_key is mandatory' unless private_key
+      fail ArgumentError, 'server_public_key is mandatory' unless server_public_key
 
       @private_key = OpenSSL::PKey::RSA.new(private_key)
       @server_public_key = OpenSSL::PKey::RSA.new(server_public_key)
     end
 
@@ -46,16 +48,16 @@
     def digest
       OpenSSL::Digest::SHA256.new
     end
 
     def verifiable_header?(header_name, _)
-      _header_name = header_name.to_s.downcase
-      _header_name.start_with?(BUNQ_HEADER_PREFIX) && _header_name != BUNQ_SERVER_SIGNATURE_RESPONSE_HEADER
+      the_header_name = header_name.to_s.downcase
+      the_header_name.start_with?(BUNQ_HEADER_PREFIX) && the_header_name != BUNQ_SERVER_SIGNATURE_RESPONSE_HEADER
     end
 
-    def skip_signature_check(responseCode)
-      (Bunq::configuration.sandbox && responseCode == 409) || responseCode == 429
+    def skip_signature_check(response_code)
+      (Bunq.configuration.sandbox && response_code == 409) || response_code == 429
     end
 
     def verify_legacy(signature, response)
       sorted_bunq_headers = response
         .raw_headers
@@ -64,10 +66,10 @@
         .to_h
         .map do |k, v|
           "#{k.to_s.split('-').map(&:capitalize).join('-')}: #{v.first}"
         end
 
-      verify(signature, %Q{#{response.code}\n#{sorted_bunq_headers.join("\n")}\n\n#{response.body}})
+      verify(signature, %(#{response.code}\n#{sorted_bunq_headers.join("\n")}\n\n#{response.body}))
     end
 
     def verify_modern(signature, response)
       verify(signature, response.body)
     end