spec/bullet/rack_spec.rb in bullet-5.7.0 vs spec/bullet/rack_spec.rb in bullet-5.7.1

- old
+ new

@@ -1,58 +1,57 @@ - require 'spec_helper' module Bullet describe Rack do let(:middleware) { Bullet::Rack.new app } let(:app) { Support::AppDouble.new } context '#html_request?' do it 'should be true if Content-Type is text/html and http body contains html tag' do headers = { 'Content-Type' => 'text/html' } - response = double(:body => '<html><head></head><body></body></html>') + response = double(body: '<html><head></head><body></body></html>') expect(middleware).to be_html_request(headers, response) end it 'should be true if Content-Type is text/html and http body contains html tag with attributes' do headers = { 'Content-Type' => 'text/html' } - response = double(:body => "<html attr='hello'><head></head><body></body></html>") + response = double(body: "<html attr='hello'><head></head><body></body></html>") expect(middleware).to be_html_request(headers, response) end it 'should be false if there is no Content-Type header' do headers = {} - response = double(:body => '<html><head></head><body></body></html>') + response = double(body: '<html><head></head><body></body></html>') expect(middleware).not_to be_html_request(headers, response) end it 'should be false if Content-Type is javascript' do headers = { 'Content-Type' => 'text/javascript' } - response = double(:body => '<html><head></head><body></body></html>') + response = double(body: '<html><head></head><body></body></html>') expect(middleware).not_to be_html_request(headers, response) end it "should be false if response body doesn't contain html tag" do headers = { 'Content-Type' => 'text/html' } - response = double(:body => '<div>Partial</div>') + response = double(body: '<div>Partial</div>') expect(middleware).not_to be_html_request(headers, response) end end context 'empty?' do it 'should be false if response is a string and not empty' do - response = double(:body => '<html><head></head><body></body></html>') + response = double(body: '<html><head></head><body></body></html>') expect(middleware).not_to be_empty(response) end it 'should be true if response is not found' do response = ['Not Found'] expect(middleware).to be_empty(response) end it 'should be true if response body is empty' do - response = double(:body => '') + response = double(body: '') expect(middleware).to be_empty(response) end end context '#call' do @@ -66,21 +65,21 @@ it 'should change response body if notification is active' do expect(Bullet).to receive(:notification?).and_return(true) expect(Bullet).to receive(:gather_inline_notifications).and_return('<bullet></bullet>') expect(Bullet).to receive(:perform_out_of_channel_notifications) - status, headers, response = middleware.call({ 'Content-Type' => 'text/html' }) + status, headers, response = middleware.call('Content-Type' => 'text/html') expect(headers['Content-Length']).to eq('56') expect(response).to eq(['<html><head></head><body><bullet></bullet></body></html>']) end it 'should set the right Content-Length if response body contains accents' do response = Support::ResponseDouble.new response.body = '<html><head></head><body>é</body></html>' app.response = response expect(Bullet).to receive(:notification?).and_return(true) expect(Bullet).to receive(:gather_inline_notifications).and_return('<bullet></bullet>') - status, headers, response = middleware.call({ 'Content-Type' => 'text/html' }) + status, headers, response = middleware.call('Content-Type' => 'text/html') expect(headers['Content-Length']).to eq('58') end end context 'when Bullet is disabled' do