spec/bovem/configuration_spec.rb in bovem-2.2.2 vs spec/bovem/configuration_spec.rb in bovem-2.3.0

@@ -14,52 +14,37 @@
   let(:log_file) { "/tmp/bovem-test-log-#{Time.now.strftime("%Y%m%d-%H%M%S")}" }
   let(:test_prefix) { "/tmp/bovem-test-#{Time.now.strftime("%Y%m%d-%H%M%S")}" }
 
   describe "#parse" do
     it "reads a valid configuration file" do
-      file = ::File.open(test_prefix, "w") {|f| f.write("config.property = 1234") }
+      ::File.open(test_prefix, "w") {|f| f.write("config.property = 1234") }
 
       config = BaseConfiguration.new(test_prefix)
       expect(config.property).to eq(1234)
       File.unlink(test_prefix)
     end
 
     it "reject a missing or unreadable file" do
-      expect { config = BaseConfiguration.new("/non-existing")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
+      expect { BaseConfiguration.new("/non-existing")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
     end
 
     it "reject an invalid configuration" do
-      file1 = ::File.open("#{test_prefix}-1", "w") {|f| f.write("config.property = ") }
-      file2 = ::File.open("#{test_prefix}-2", "w") {|f| f.write("config.non_property = 1234") }
+      ::File.open("#{test_prefix}-1", "w") {|f| f.write("config.property = ") }
+      ::File.open("#{test_prefix}-2", "w") {|f| f.write("config.non_property = 1234") }
 
-      expect { config = BaseConfiguration.new("#{test_prefix}-1")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
-      expect { config = BaseConfiguration.new("#{test_prefix}-2")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
+      expect { BaseConfiguration.new("#{test_prefix}-1")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
+      expect { BaseConfiguration.new("#{test_prefix}-2")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
 
       File.unlink("#{test_prefix}-1")
       File.unlink("#{test_prefix}-2")
     end
 
     it "allows overrides" do
-      file = ::File.open("#{test_prefix}", "w") {|f| f.write("config.property = 1234") }
+      ::File.open("#{test_prefix}", "w") {|f| f.write("config.property = 1234") }
 
       config = BaseConfiguration.new(test_prefix, {property: 5678, non_property: 1234})
       expect(config.property).to eq(5678)
 
       File.unlink(test_prefix)
-    end
-  end
-
-  describe ".property" do
-    it "add the property to the object" do
-      subject = BaseConfiguration.new
-
-      expect(subject.respond_to?(:new_property)).to be_false
-      expect(subject.respond_to?(:new_property=)).to be_false
-      BaseConfiguration.property(:new_property, default: "VALUE")
-      expect(subject.respond_to?(:new_property)).to be_true
-      expect(subject.respond_to?(:new_property=)).to be_true
-      expect(subject.new_property).to eq("VALUE")
-      subject.new_property = "NEW VALUE"
-      expect(subject.new_property).to eq("NEW VALUE")
     end
   end
 end
\ No newline at end of file