test/test_executor.rb in bobes-textmagic-0.1.0 vs test/test_executor.rb in bobes-textmagic-0.2.0

@@ -11,24 +11,57 @@
       @username, @password = random_string, random_string
       @command, @options = random_string, random_hash
       @uri = build_uri(@command, @username, @password, @options)
     end
 
+    should 'not send HTTP request without command' do
+      TextMagic::API::Executor.expects(:get).never
+      lambda {
+        TextMagic::API::Executor.execute(nil, @username, @password, @options)
+      }.should raise_error(TextMagic::API::Error)
+    end
+
+    should 'not send HTTP request without username' do
+      TextMagic::API::Executor.expects(:get).never
+      lambda {
+        TextMagic::API::Executor.execute(@command, nil, @password, @options)
+      }.should raise_error(TextMagic::API::Error)
+    end
+
+    should 'not send HTTP request without password' do
+      TextMagic::API::Executor.expects(:get).never
+      lambda {
+        TextMagic::API::Executor.execute(@command, @username, nil, @options)
+      }.should raise_error(TextMagic::API::Error)
+    end
+
     should 'send a GET request to proper uri' do
       response = random_string
       FakeWeb.register_uri(:get, @uri, :string => response)
       TextMagic::API::Executor.execute(@command, @username, @password, @options)
     end
 
+    should 'not send parameters with empty keys' do
+      options_with_empty_values = @options.merge(nil => random_string, '' => random_string)
+      TextMagic::API::Executor.expects(:get).with('/api', :query => @options, :format => :json)
+      TextMagic::API::Executor.execute(@command, @username, @password, options_with_empty_values)
+    end
+
+    should 'not send parameters with empty values' do
+      options_with_empty_values = @options.merge(random_string => nil, random_string => '')
+      TextMagic::API::Executor.expects(:get).with('/api', :query => @options, :format => :json)
+      TextMagic::API::Executor.execute(@command, @username, @password, options_with_empty_values)
+    end
+
     should 'raise an error if the response contains error_code' do
       response = "{error_code:#{1 + rand(10)}}"
       FakeWeb.register_uri(:get, @uri, :string => response)
       lambda {
         TextMagic::API::Executor.execute(@command, @username, @password, @options)
       }.should raise_error(TextMagic::API::Error)
     end
 
-    should 'return a hash with values in the response' do
+    should 'return a hash with values from the response' do
       hash = random_hash
       FakeWeb.register_uri(:get, @uri, :string => hash.to_json)
       response = TextMagic::API::Executor.execute(@command, @username, @password, @options)
       response.should == hash
     end