lib/bitwise.rb in bitwise-0.2.0 vs lib/bitwise.rb in bitwise-0.3.0

@@ -3,12 +3,12 @@
 require 'bitwise/bitwise'
 
 class Bitwise
   attr_accessor :value
 
-  def initialize(size = 0)
-    @value = "\x00" * size
+  def initialize(value = "")
+    @value = value.force_encoding(Encoding::ASCII_8BIT)
   end
 
   def size
     @value.bytesize
   end
@@ -49,38 +49,34 @@
     @div, @mod = index.divmod(8)
     @byte = @value.getbyte(@div)
   end
 
   def not
-    result = Bitwise.new
-    result.value = Bitwise.string_not(self.value)
-    result
+    Bitwise.new(Bitwise.string_not(self.value))
   end
   alias :~ :not
 
   def intersect(other)
-    min, max = [ self.value, other.value ].sort_by{|i| i.bytesize }
-    result = Bitwise.new
-    result.value = Bitwise.string_intersect(max, min)
-    result
+    assign_max_and_min(other)
+    Bitwise.new Bitwise.string_intersect(@max, @min)
   end
   alias :& :intersect
 
   def union(other)
-    min, max = [ self.value, other.value ].sort_by{|i| i.bytesize }
-    result = Bitwise.new
-    result.value = Bitwise.string_union(max, min)
-    result
+    assign_max_and_min(other)
+    Bitwise.new Bitwise.string_union(@max, @min)
   end
   alias :| :union
 
   def xor(other)
-    min, max = [ self.value, other.value ].sort_by{|i| i.bytesize }
-    result = Bitwise.new
-    result.value = Bitwise.string_xor(max, min)
-    result
+    assign_max_and_min(other)
+    Bitwise.new Bitwise.string_xor(@max, @min)
   end
   alias :^ :xor
+
+  def assign_max_and_min(other)
+    @min, @max = [ self.value, other.value ].sort_by{|i| i.bytesize }
+  end
 
   def value=(string)
     @value = string.force_encoding(Encoding::ASCII_8BIT)
     @value.bytesize
   end