lib/bitcoiner/client.rb in bitcoiner-0.1.1 vs lib/bitcoiner/client.rb in bitcoiner-0.1.2

@@ -1,9 +1,16 @@
+# frozen_string_literal: true
+
 module Bitcoiner
   class Client
-    def initialize(user, pass, host = '127.0.0.1:8332')
-      @endpoint = "http://#{user}:#{pass}@#{host}"
+    attr_accessor :endpoint
+
+    def initialize(user, pass, host)
+      uri = Addressable::URI.heuristic_parse(host)
+      uri.user ||= user
+      uri.password ||= pass
+      self.endpoint = uri.to_s
     end
 
     def balance
       request 'getbalance'
     end
@@ -13,18 +20,31 @@
       AccountHash.new self, balance_hash
     end
 
     def request(method, *args)
       post_body = { 'method' => method, 'params' => args, 'id' => 'jsonrpc' }.to_json
-      response = Typhoeus.post(@endpoint, body: post_body)
-      response_hash = JSON.parse response.body
+      response = Typhoeus.post(endpoint, body: post_body)
+      response_hash = parse_body(response)
       raise JSONRPCError, response_hash['error'] if response_hash['error']
       response_hash['result']
     end
 
     def inspect
-      "#<Bitcoiner::Client #{@endpoint.inspect} >"
+      "#<Bitcoiner::Client #{endpoint.inspect} >"
     end
 
     class JSONRPCError < RuntimeError; end
+
+    private
+
+    def parse_body(response)
+      if response.success?
+        JSON.parse(response.body)
+      else
+        error_message = %i[code return_code].map do |attr|
+          "#{attr}: `#{response.send(attr)}`"
+        end.join(', ')
+        raise JSONRPCError, "unsuccessful response; #{error_message}"
+      end
+    end
   end
 end