.rubocop_todo.yml in beaker-5.2.0 vs .rubocop_todo.yml in beaker-5.3.0
- old
+ new
@@ -1,13 +1,14 @@
# This configuration was generated by
-# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.50.1.
+# `rubocop --auto-gen-config`
+# on 2023-05-30 09:17:22 UTC using RuboCop version 1.50.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
+# Offense count: 15
# Configuration parameters: AllowedMethods.
# AllowedMethods: enums
Lint/ConstantDefinitionInBlock:
Exclude:
- 'Rakefile'
@@ -24,46 +25,74 @@
- 'spec/beaker/host/windows/exec_spec.rb'
- 'spec/beaker/host/windows/group_spec.rb'
- 'spec/beaker/host/windows/pkg_spec.rb'
- 'spec/beaker/options/hosts_file_parser_spec.rb'
+# Offense count: 17
# Configuration parameters: AllowComments, AllowEmptyLambdas.
Lint/EmptyBlock:
Exclude:
- 'acceptance/tests/base/host/group_test.rb'
- 'acceptance/tests/base/host/user_test.rb'
- 'spec/beaker/dsl/structure_spec.rb'
- 'spec/beaker/logger_junit_spec.rb'
- 'spec/beaker/logger_spec.rb'
+# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
Lint/NonAtomicFileOperation:
Exclude:
- 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+# Offense count: 2
Lint/RescueException:
Exclude:
- 'lib/beaker/dsl/structure.rb'
- 'lib/beaker/test_suite_result.rb'
+# Offense count: 27
Lint/ShadowingOuterLocalVariable:
Exclude:
- 'lib/beaker/dsl/helpers/host_helpers.rb'
- 'lib/beaker/dsl/helpers/web_helpers.rb'
- 'lib/beaker/dsl/wrappers.rb'
- 'lib/beaker/host/pswindows/exec.rb'
- 'lib/beaker/host/unix/pkg.rb'
- 'lib/beaker/host_prebuilt_steps.rb'
- 'lib/beaker/perf.rb'
+# Offense count: 12
Lint/UselessAssignment:
Exclude:
- 'acceptance/tests/base/dsl/helpers/host_helpers/curl_with_retries_test.rb'
- 'lib/beaker/cli.rb'
- 'lib/beaker/dsl/helpers/host_helpers.rb'
- 'lib/beaker/logger_junit.rb'
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Minitest/AssertTruthy:
+ Exclude:
+ - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+ - 'acceptance/tests/base/host/host_test.rb'
+ - 'acceptance/tests/hypervisor/communication_test.rb'
+
+# Offense count: 2
+# Configuration parameters: Severity.
+Minitest/AssertWithExpectedArgument:
+ Exclude:
+ - 'acceptance/tests/base/dsl/helpers/hocon_helpers_test.rb'
+
+# Offense count: 9
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Minitest/RefuteFalse:
+ Exclude:
+ - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+ - 'acceptance/tests/base/dsl/helpers/host_helpers/check_for_package_test.rb'
+ - 'acceptance/tests/base/host/host_test.rb'
+
+# Offense count: 20
# Configuration parameters: ForbiddenDelimiters.
# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
Naming/HeredocDelimiterNaming:
Exclude:
- 'Rakefile'
@@ -75,46 +104,53 @@
- 'spec/beaker/host/windows/group_spec.rb'
- 'spec/beaker/host/windows/user_spec.rb'
- 'spec/beaker/host/windows_spec.rb'
- 'spec/beaker/test_case_spec.rb'
+# Offense count: 2
# Configuration parameters: EnforcedStyleForLeadingUnderscores.
# SupportedStylesForLeadingUnderscores: disallowed, required, optional
Naming/MemoizedInstanceVariableName:
Exclude:
- 'lib/beaker/host.rb'
- 'lib/beaker/options/presets.rb'
+# Offense count: 4
# Configuration parameters: MinSize.
Performance/CollectionLiteralInLoop:
Exclude:
- 'acceptance/fixtures/module/spec/spec_helper_acceptance.rb'
- 'lib/beaker/dsl/structure.rb'
- 'lib/beaker/test_suite_result.rb'
+# Offense count: 17
RSpec/AnyInstance:
Exclude:
- 'spec/beaker/host/windows/file_spec.rb'
- 'spec/beaker/subcommand_spec.rb'
+# Offense count: 12
# This cop supports unsafe autocorrection (--autocorrect-all).
RSpec/BeEq:
Exclude:
- 'spec/beaker/cli_spec.rb'
- 'spec/beaker/host/pswindows/file_spec.rb'
- 'spec/beaker/host/windows/exec_spec.rb'
- 'spec/beaker/host_spec.rb'
+# Offense count: 121
# Configuration parameters: Prefixes, AllowedPatterns.
# Prefixes: when, with, without
RSpec/ContextWording:
Enabled: false
+# Offense count: 239
# Configuration parameters: CountAsOne.
RSpec/ExampleLength:
Max: 44
+# Offense count: 27
RSpec/ExpectInHook:
Exclude:
- 'spec/beaker/cli_spec.rb'
- 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
- 'spec/beaker/host/unix/exec_spec.rb'
@@ -122,23 +158,26 @@
- 'spec/beaker/host_prebuilt_steps_spec.rb'
- 'spec/beaker/logger_spec.rb'
- 'spec/beaker/options/parser_spec.rb'
- 'spec/beaker/ssh_connection_spec.rb'
+# Offense count: 22
# Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable:
Exclude:
- 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
- 'spec/beaker/dsl/helpers/test_helpers_spec.rb'
- 'spec/beaker/dsl/roles_spec.rb'
- 'spec/beaker/dsl/test_tagging_spec.rb'
- 'spec/beaker/host_prebuilt_steps_spec.rb'
+# Offense count: 3
RSpec/IteratedExpectation:
Exclude:
- 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
+# Offense count: 12
RSpec/LeakyConstantDeclaration:
Exclude:
- 'spec/beaker/host/freebsd/exec_spec.rb'
- 'spec/beaker/host/freebsd/pkg_spec.rb'
- 'spec/beaker/host/mac/exec_spec.rb'
@@ -150,44 +189,51 @@
- 'spec/beaker/host/windows/exec_spec.rb'
- 'spec/beaker/host/windows/group_spec.rb'
- 'spec/beaker/host/windows/pkg_spec.rb'
- 'spec/beaker/options/hosts_file_parser_spec.rb'
+# Offense count: 1
RSpec/MultipleDescribes:
Exclude:
- 'spec/beaker/dsl/test_tagging_spec.rb'
+# Offense count: 134
# Configuration parameters: AllowSubject.
RSpec/MultipleMemoizedHelpers:
Max: 17
+# Offense count: 500
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
# SupportedStyles: always, named_only
RSpec/NamedSubject:
Enabled: false
+# Offense count: 42
# Configuration parameters: AllowedPatterns.
# AllowedPatterns: ^expect_, ^assert_
RSpec/NoExpectationExample:
Exclude:
- 'acceptance/fixtures/module/spec/acceptance/demo_spec.rb'
- 'spec/beaker/host/windows/pkg_spec.rb'
- 'spec/beaker/host_prebuilt_steps_spec.rb'
- 'spec/beaker/logger_spec.rb'
- 'spec/beaker/options/subcommand_options_parser_spec.rb'
+# Offense count: 7
RSpec/RepeatedDescription:
Exclude:
- 'spec/beaker/cli_spec.rb'
- 'spec/beaker/host/unix/exec_spec.rb'
- 'spec/beaker/host/unix/pkg_spec.rb'
+# Offense count: 4
RSpec/RepeatedExample:
Exclude:
- 'spec/beaker/dsl/roles_spec.rb'
- 'spec/beaker/logger_spec.rb'
+# Offense count: 178
RSpec/SubjectStub:
Exclude:
- 'spec/beaker/dsl/assertions_spec.rb'
- 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
- 'spec/beaker/dsl/helpers/test_helpers_spec.rb'
@@ -200,39 +246,45 @@
- 'spec/beaker/host/mac/user_spec.rb'
- 'spec/beaker/host/pswindows/user_spec.rb'
- 'spec/beaker/host/windows/user_spec.rb'
- 'spec/beaker/host_prebuilt_steps_spec.rb'
+# Offense count: 12
RSpec/UnspecifiedException:
Exclude:
- 'spec/beaker/cli_spec.rb'
- 'spec/beaker/host/unix/pkg_spec.rb'
- 'spec/beaker/host_spec.rb'
- 'spec/beaker/test_suite_spec.rb'
+# Offense count: 86
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
RSpec/VerifiedDoubles:
Enabled: false
+# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
Rake/Desc:
Exclude:
- 'Rakefile'
+# Offense count: 7
Security/Eval:
Exclude:
- 'Rakefile'
- 'acceptance/config/base/acceptance-options.rb'
- 'acceptance/config/hypervisor/acceptance-options.rb'
- 'acceptance/config/subcommands/acceptance-options.rb'
- 'lib/beaker/command.rb'
- 'lib/beaker/options/options_file_parser.rb'
- 'lib/beaker/test_case.rb'
+# Offense count: 1
Security/Open:
Exclude:
- 'lib/beaker/dsl/helpers/web_helpers.rb'
+# Offense count: 104
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https
Layout/LineLength:
Max: 225