spec/validation_spec.rb in bagit-0.4.3 vs spec/validation_spec.rb in bagit-0.4.4

- old
+ new

@@ -1,19 +1,20 @@ -# coding: utf-8 -require 'spec_helper' +# frozen_string_literal: true +require "spec_helper" + describe BagIt::Bag do describe "a valid bag" do before do @sandbox = Sandbox.new # make the bag - @bag_path = File.join @sandbox.to_s, 'the_bag' + @bag_path = File.join @sandbox.to_s, "the_bag" @bag = described_class.new @bag_path # add some files - File.open('/dev/urandom') do |rio| + File.open("/dev/urandom") do |rio| 10.times do |n| @bag.add_file("file-#{n}-💩 ") { |io| io.write rio.read(16) } @bag.add_tag_file("tag-#{n}") { |io| io.write rio.read(16) } end @@ -30,80 +31,80 @@ expect(@bag).to be_valid end it "is invalid if there is a file that's in the bag, but not in the manifest" do # add a file into the bag through the back door - File.open(File.join(@bag.data_dir, 'not-manifested'), 'w') do |io| - io.puts 'nothing to see here, move along' + File.open(File.join(@bag.data_dir, "not-manifested"), "w") do |io| + io.puts "nothing to see here, move along" end - @bag.validate_only('true_for/completeness') + @bag.validate_only("true_for/completeness") expect(@bag.errors.on(:completeness)).not_to be_empty expect(@bag).not_to be_valid end it "is invalid if there are files that are in the manifest but not in the bag" do # add a file and then remove it through the back door - @bag.add_file("file-k") { |io| io.puts 'time to go' } + @bag.add_file("file-k") { |io| io.puts "time to go" } @bag.manifest! - FileUtils.rm File.join(@bag.bag_dir, 'data', 'file-k') + FileUtils.rm File.join(@bag.bag_dir, "data", "file-k") - @bag.validate_only('true_for/completeness') + @bag.validate_only("true_for/completeness") expect(@bag.errors.on(:completeness)).not_to be_empty expect(@bag).not_to be_valid end it "is invalid if there is a fixity problem" do # tweak a file through the back door - File.open(@bag.bag_files[0], 'a') { |io| io.puts 'oops!' } + File.open(@bag.bag_files[0], "a") { |io| io.puts "oops!" } - @bag.validate_only('true_for/consistency') + @bag.validate_only("true_for/consistency") expect(@bag.errors.on(:consistency)).not_to be_empty expect(@bag).not_to be_valid end it "calculates sha1 correctly for a big file" do - @bag.add_file 'big-data-file' do |fh| + @bag.add_file "big-data-file" do |fh| count = 0 while count < 1024 * 512 fh.write "1" * 1024 count += 1 end end @bag.manifest! - sha1_manifest = File.join @bag_path, 'manifest-sha1.txt' + sha1_manifest = File.join @bag_path, "manifest-sha1.txt" checksums = {} File.open(sha1_manifest).each_line do |line| - fixity, path = line.split(' ') + fixity, path = line.split(" ") checksums[path] = fixity end - expected = checksums['data/big-data-file'] - expect(expected).to eq('12be64c30968bb90136ee695dc58f4b2276968c6') + expected = checksums["data/big-data-file"] + expect(expected).to eq("12be64c30968bb90136ee695dc58f4b2276968c6") end it "validates by oxum when needed" do expect(@bag.valid_oxum?).to eq(true) end it "raises a sensible error when the manifest algorithm is unknown" do # add a manifest with an unsupported algorithm - File.open(File.join(@bag.bag_dir, 'manifest-sha999.txt'), 'w') do |io| + File.open(File.join(@bag.bag_dir, "manifest-sha999.txt"), "w") do |io| io.puts "digest-does-not-matter data/file-0\n" end expect { @bag.valid? }.to raise_error ArgumentError end it "validates false by oxum when file count is incorrect" do # tweak oxum through backdoor - File.open(@bag.bag_info_txt_file, 'a') { |f| f.write "Payload-Oxum: " + @bag.bag_info["Payload-Oxum"].split('.')[0] + '.0' } + File.open(@bag.bag_info_txt_file, "a") { |f| f.write "Payload-Oxum: " + @bag.bag_info["Payload-Oxum"].split(".")[0] + ".0" } expect(@bag.valid_oxum?).to eq(false) end it "validates false by oxum when octetstream size is incorrect" do # tweak oxum through backdoor - File.open(@bag.bag_info_txt_file, 'a') { |f| f.write "Payload-Oxum: 1." + @bag.bag_info["Payload-Oxum"].split('.')[1] } + File.open(@bag.bag_info_txt_file, "a") { |f| f.write "Payload-Oxum: 1." + @bag.bag_info["Payload-Oxum"].split(".")[1] } expect(@bag.valid_oxum?).to eq(false) end describe "tag manifest validation" do it "is invalid if there are no manifest files at all even when there are no files" do @@ -125,13 +126,13 @@ end describe "tag manifest validation" do it "is invalid if listed tag file does not exist" do # add a file and then remove it through the back door - @bag.add_tag_file("tag-k") { |io| io.puts 'time to go' } + @bag.add_tag_file("tag-k") { |io| io.puts "time to go" } @bag.tagmanifest! - FileUtils.rm File.join(@bag.bag_dir, 'tag-k') + FileUtils.rm File.join(@bag.bag_dir, "tag-k") # @bag.should_not be_valid expect(@bag).not_to be_valid expect(@bag.errors.on(:completeness)).not_to be_empty end