validation_spec.rb in bagit-0.3.4

- old
+ new

@@ -1,5 +1,6 @@
+# coding: utf-8
 require 'spec_helper'
 
 describe "a valid bag" do
 
   before(:each) do
@@ -12,11 +13,12 @@
 
     # add some files
     File.open('/dev/urandom') do |rio|
 
       10.times do |n|
-        @bag.add_file("file-#{n}") { |io| io.write rio.read(16) }
+        @bag.add_file("file-#{n}-💩
+") { |io| io.write rio.read(16) }
         @bag.add_tag_file("tag-#{n}") { |io| io.write rio.read(16) }
       end
 
     end
 
@@ -26,43 +28,43 @@
   after(:each) do
     @sandbox.cleanup!
   end
 
   it "should validate with no errors" do
-    @bag.should be_valid
+    expect(@bag).to be_valid
   end
 
-  it "should not be lewd (some file is not covered by the manifest)" do
+  it "should be invalid if there is a file that's in the bag, but not in the manifest" do
     # add a file into the bag through the back door
     File.open(File.join(@bag.data_dir, 'not-manifested'), 'w') do |io|
       io.puts 'nothing to see here, move along'
     end
 
     @bag.validate_only('true_for/completeness')
-    @bag.errors.on(:completeness).should_not be_empty
-    @bag.should_not be_valid
+    expect(@bag.errors.on(:completeness)).not_to be_empty
+    expect(@bag).not_to be_valid
   end
 
-  it "should not be prude (the manifest covers files that do not exist)" do
+  it "should be invalid if there are files that are in the manifest but not in the bag" do
     # add a file and then remove it through the back door
     @bag.add_file("file-k") { |io| io.puts 'time to go' }
     @bag.manifest!
 
     FileUtils::rm File.join(@bag.bag_dir, 'data', 'file-k')
 
     @bag.validate_only('true_for/completeness')
-    @bag.errors.on(:completeness).should_not be_empty
-    @bag.should_not be_valid
+    expect(@bag.errors.on(:completeness)).not_to be_empty
+    expect(@bag).not_to be_valid
   end
 
-  it "should be consistent (fixity)" do
+  it "should be invalid if there is a fixity problem" do
     # tweak a file through the back door
     File.open(@bag.bag_files[0], 'a') { |io| io.puts 'oops!' }
 
     @bag.validate_only('true_for/consistency')
-    @bag.errors.on(:consistency).should_not be_empty
-    @bag.should_not be_valid
+    expect(@bag.errors.on(:consistency)).not_to be_empty
+    expect(@bag).not_to be_valid
   end
 
   it "should calculate sha1 correctly for a big file" do
     @bag.add_file 'big-data-file' do |fh|
       count = 0
@@ -77,39 +79,66 @@
     File.open(sha1_manifest).each_line do |line|
         fixity, path = line.split(' ')
         checksums[path] = fixity
     end
     expected = checksums['data/big-data-file']
-    expected.should == '12be64c30968bb90136ee695dc58f4b2276968c6'
+    expect(expected).to eq('12be64c30968bb90136ee695dc58f4b2276968c6')
   end
 
   it "should validate by oxum when needed" do
-    @bag.valid_oxum?.should == true
+    expect(@bag.valid_oxum?).to eq(true)
   end
 
+   it "should raise an sensible error when the manifest algorithm is unknown" do
+     # add a manifest with an unsupported algorithm
+     File.open(File.join(@bag.bag_dir, 'manifest-sha999.txt'), 'w') do |io|
+       io.puts "digest-does-not-matter data/file-0\n"
+     end
+     expect { @bag.valid? }.to raise_error ArgumentError
+   end
+  
   it "should validate false by oxum when file count is incorrect" do
     # tweak oxum through backdoor
     File.open(@bag.bag_info_txt_file, 'a') { |f| f.write "Payload-Oxum: " + @bag.bag_info["Payload-Oxum"].split('.')[0] + '.0' }
-    @bag.valid_oxum?.should == false
+    expect(@bag.valid_oxum?).to eq(false)
   end
 
   it "should validate false by oxum when octetstream size is incorrect" do
     # tweak oxum through backdoor
     File.open(@bag.bag_info_txt_file, 'a') { |f| f.write "Payload-Oxum: 1." + @bag.bag_info["Payload-Oxum"].split('.')[1] }
-    @bag.valid_oxum?.should == false
+    expect(@bag.valid_oxum?).to eq(false)
   end
 
+   describe "tag manifest validation" do
+    it "should be invalid if there are no manifest files at all even when there are no files" do
+      #remove all files, tag/manifest files & tagmanifest files through the back door
+      @bag.bag_files.each do |bag_file|
+        FileUtils::rm bag_file
+      end
+      @bag.tag_files.each do |tag_file|
+        FileUtils::rm tag_file
+      end
+      @bag.tagmanifest_files.each do |tagmanifest_file|
+        FileUtils::rm tagmanifest_file
+      end
+
+      # @bag.should_not be_valid
+      expect(@bag).not_to be_valid
+      expect(@bag.errors.on(:completeness)).not_to be_empty
+    end
+   end
+
   describe "tag manifest validation" do
     it "should be invalid if listed tag file does not exist" do
       # add a file and then remove it through the back door
       @bag.add_tag_file("tag-k") { |io| io.puts 'time to go' }
       @bag.tagmanifest!
 
       FileUtils::rm File.join(@bag.bag_dir, 'tag-k')
 
       # @bag.should_not be_valid
-      @bag.should_not be_valid
-      @bag.errors.on(:completeness).should_not be_empty
+      expect(@bag).not_to be_valid
+      expect(@bag.errors.on(:completeness)).not_to be_empty
     end
   end
 
 end