spec/httparty_spec.rb in alexvollmer-httparty-0.2.6 vs spec/httparty_spec.rb in alexvollmer-httparty-0.3.1
- old
+ new
@@ -1,38 +1,27 @@
require File.join(File.dirname(__FILE__), 'spec_helper')
-class Foo
- include HTTParty
- base_uri 'api.foo.com/v1'
-end
-
-class GRest
- include HTTParty
- base_uri "grest.com"
- default_params :one => 'two'
-end
-
-class HRest
- include HTTParty
- base_uri "hrest.com"
- default_params :two => 'three'
-end
-
describe HTTParty do
-
+ before(:each) do
+ @klass = Class.new do
+ include HTTParty
+ base_uri "http://api.foo.com"
+ end
+ end
+
describe "base uri" do
- before do
- Foo.base_uri('api.foo.com/v1')
+ before(:each) do
+ @klass.base_uri('api.foo.com/v1')
end
it "should have reader" do
- Foo.base_uri.should == 'http://api.foo.com/v1'
+ @klass.base_uri.should == 'http://api.foo.com/v1'
end
it 'should have writer' do
- Foo.base_uri('http://api.foobar.com')
- Foo.base_uri.should == 'http://api.foobar.com'
+ @klass.base_uri('http://api.foobar.com')
+ @klass.base_uri.should == 'http://api.foobar.com'
end
end
describe "#normalize_base_uri" do
it "should add http if not present for non ssl requests" do
@@ -51,95 +40,153 @@
end
end
describe "headers" do
it "should default to empty hash" do
- Foo.headers.should == {}
+ @klass.headers.should == {}
end
it "should be able to be updated" do
init_headers = {:foo => 'bar', :baz => 'spax'}
- Foo.headers init_headers
- Foo.headers.should == init_headers
+ @klass.headers init_headers
+ @klass.headers.should == init_headers
end
end
+
+ describe "cookies" do
+ def expect_cookie_header(s)
+ HTTParty::Request.should_receive(:new) \
+ .with(anything, anything, hash_including({ :headers => { "cookie" => s } })) \
+ .and_return(mock("mock response", :perform => nil))
+ end
+
+ it "should not be in the headers by default" do
+ HTTParty::Request.stub!(:new).and_return(stub(nil, :perform => nil))
+ @klass.get("")
+ @klass.headers.keys.should_not include("cookie")
+ end
+
+ it "should raise an ArgumentError if passed a non-Hash" do
+ lambda do
+ @klass.cookies("nonsense")
+ end.should raise_error(ArgumentError)
+ end
+
+ it "should allow a cookie to be specified with a one-off request" do
+ expect_cookie_header "type=snickerdoodle"
+ @klass.get("", :cookies => { :type => "snickerdoodle" })
+ end
+
+ describe "when a cookie is set at the class level" do
+ before(:each) do
+ @klass.cookies({ :type => "snickerdoodle" })
+ end
+
+ it "should include that cookie in the request" do
+ expect_cookie_header "type=snickerdoodle"
+ @klass.get("")
+ end
+
+ it "should allow the class defaults to be overridden" do
+ expect_cookie_header "type=chocolate_chip"
+
+ @klass.get("", :cookies => { :type => "chocolate_chip" })
+ end
+ end
+
+ describe "in a class with multiple methods that use different cookies" do
+ before(:each) do
+ @klass.instance_eval do
+ def first_method
+ get("first_method", :cookies => { :first_method_cookie => "foo" })
+ end
+
+ def second_method
+ get("second_method", :cookies => { :second_method_cookie => "foo" })
+ end
+ end
+ end
+
+ it "should not allow cookies used in one method to carry over into other methods" do
+ expect_cookie_header "first_method_cookie=foo"
+ @klass.first_method
+
+ expect_cookie_header "second_method_cookie=foo"
+ @klass.second_method
+ end
+ end
+ end
describe "default params" do
it "should default to empty hash" do
- Foo.default_params.should == {}
+ @klass.default_params.should == {}
end
it "should be able to be updated" do
new_defaults = {:foo => 'bar', :baz => 'spax'}
- Foo.default_params new_defaults
- Foo.default_params.should == new_defaults
+ @klass.default_params new_defaults
+ @klass.default_params.should == new_defaults
end
end
describe "basic http authentication" do
it "should work" do
- Foo.basic_auth 'foobar', 'secret'
- Foo.default_options[:basic_auth].should == {:username => 'foobar', :password => 'secret'}
+ @klass.basic_auth 'foobar', 'secret'
+ @klass.default_options[:basic_auth].should == {:username => 'foobar', :password => 'secret'}
end
end
describe "format" do
it "should allow xml" do
- Foo.format :xml
- Foo.default_options[:format].should == :xml
+ @klass.format :xml
+ @klass.default_options[:format].should == :xml
end
it "should allow json" do
- Foo.format :json
- Foo.default_options[:format].should == :json
+ @klass.format :json
+ @klass.default_options[:format].should == :json
end
+ it "should allow yaml" do
+ @klass.format :yaml
+ @klass.default_options[:format].should == :yaml
+ end
+
it 'should not allow funky format' do
lambda do
- Foo.format :foobar
+ @klass.format :foobar
end.should raise_error(HTTParty::UnsupportedFormat)
end
end
- describe "with explicit override of automatic redirect handling" do
+ describe "with multiple class definitions" do
+ before(:each) do
+ @klass.instance_eval do
+ base_uri "http://first.com"
+ default_params :one => 1
+ end
- it "should fail with redirected GET" do
- lambda do
- Foo.get('/foo', :no_follow => true)
- end.should raise_error(HTTParty::RedirectionTooDeep)
+ @additional_klass = Class.new
+ @additional_klass.instance_eval do
+ include HTTParty
+ base_uri "http://second.com"
+ default_params :two => 2
+ end
end
- it "should fail with redirected POST" do
- lambda do
- Foo.post('/foo', :no_follow => true)
- end.should raise_error(HTTParty::RedirectionTooDeep)
- end
-
- it "should fail with redirected DELETE" do
- lambda do
- Foo.delete('/foo', :no_follow => true)
- end.should raise_error(HTTParty::RedirectionTooDeep)
- end
-
- it "should fail with redirected PUT" do
- lambda do
- Foo.put('/foo', :no_follow => true)
- end.should raise_error(HTTParty::RedirectionTooDeep)
- end
- end
-
- describe "with multiple class definitions" do
it "should not run over each others options" do
- HRest.default_options.should == {:base_uri => 'http://hrest.com', :default_params => {:two => 'three'}}
- GRest.default_options.should == {:base_uri => 'http://grest.com', :default_params => {:one => 'two'}}
+ @klass.default_options.should == { :base_uri => 'http://first.com', :default_params => { :one => 1 } }
+ @additional_klass.default_options.should == { :base_uri => 'http://second.com', :default_params => { :two => 2 } }
end
end
describe "#get" do
it "should be able to get html" do
stub_http_response_with('google.html')
- HTTParty.get('http://www.google.com').should == file_fixture('google.html')
+ resp = HTTParty.get('http://www.google.com')
+ resp.should == file_fixture('google.html')
+ resp.body.should == file_fixture('google.html')
end
it "should be able parse response type json automatically" do
stub_http_response_with('twitter.json')
tweets = HTTParty.get('http://twitter.com/statuses/public_timeline.json')
@@ -153,10 +200,11 @@
"screen_name" => "Pyk",
"followers_count" => 1,
"location" => "Opera Plaza, California",
"profile_image_url" => "http://static.twitter.com/images/default_profile_normal.png"
}
+ tweets.body.should == file_fixture('twitter.json')
end
it "should be able parse response type xml automatically" do
stub_http_response_with('twitter.xml')
tweets = HTTParty.get('http://twitter.com/statuses/public_timeline.xml')
@@ -170,8 +218,21 @@
"screen_name" => "magic8bot",
"followers_count" => "90",
"profile_image_url" => "http://s3.amazonaws.com/twitter_production/profile_images/65565851/8ball_large_normal.jpg",
"location" => nil
}
+ tweets.body.should == file_fixture('twitter.xml')
+ end
+
+ it "should not get undefined method add_node for nil class for the following xml" do
+ stub_http_response_with('undefined_method_add_node_for_nil.xml')
+ result = HTTParty.get('http://foobar.com')
+ result.should == {"Entities"=>{"href"=>"https://s3-sandbox.parature.com/api/v1/5578/5633/Account", "results"=>"0", "total"=>"0", "page_size"=>"25", "page"=>"1"}}
+ end
+
+ it "should parse empty response fine" do
+ stub_http_response_with('empty.xml')
+ result = HTTParty.get('http://foobar.com')
+ result.should == nil
end
end
end