.rubocop.yml in alarmable-0.1.2 vs .rubocop.yml in alarmable-1.0.0

- old
+ new

@@ -1,16 +1,21 @@ -require: rubocop-rspec +require: + - rubocop-rspec + - rubocop-rails Rails: Enabled: true -Documentation: +Style/Documentation: Enabled: true AllCops: + NewCops: enable + SuggestExtensions: false DisplayCopNames: true TargetRubyVersion: 2.5 + TargetRailsVersion: 5.2 Exclude: - bin/**/* - vendor/**/* - build/**/* - gemfiles/**/* @@ -21,10 +26,14 @@ - '*.gemspec' - spec/**/*.rb - '**/*.rake' - doc/**/*.rb +# MFA is not yet enabled for our gems yet. +Gemspec/RequireMFA: + Enabled: false + # Document all the things. Style/DocumentationMethod: Enabled: true RequireForNonPublicMethods: true @@ -37,10 +46,14 @@ # Because +expect_any_instance_of().to have_received()+ is not # supported with the +with(hash_including)+ matchers RSpec/MessageSpies: EnforcedStyle: receive +# We stay with the original Ruby Style Guide recommendation. +Layout/LineLength: + Max: 80 + # Because nesting makes sense here to group the feature tests # more effective. This increases maintainability. RSpec/NestedGroups: Max: 4 @@ -61,6 +74,10 @@ Enabled: false # Because +enqueued_jobs+ is a method not a memoized variable, # so when first evaluated it won't change. RSpec/ExpectChange: + Enabled: false + +# We highly depend on memoized helpers across the specs. +RSpec/MultipleMemoizedHelpers: Enabled: false