lib/active_merchant/billing/gateways/secure_net.rb in activemerchant-1.54.0 vs lib/active_merchant/billing/gateways/secure_net.rb in activemerchant-1.55.0
- old
+ new
@@ -161,13 +161,11 @@
xml.tag! 'CITY', address[:city].to_s
xml.tag! 'COMPANY', address[:company].to_s
xml.tag! 'COUNTRY', address[:country].to_s
if address[:name]
- names = address[:name].split
- last_name = names.pop
- first_name = names.join(" ")
+ first_name, last_name = split_names(address[:name])
xml.tag! 'FIRSTNAME', first_name
xml.tag! 'LASTNAME', last_name
else
xml.tag! 'FIRSTNAME', address[:first_name].to_s
xml.tag! 'LASTNAME', address[:last_name].to_s
@@ -206,11 +204,12 @@
xml.tag! 'ORDERID', truncate(options[:order_id], 25)
xml.tag! 'OVERRIDE_FROM', 0 # Docs say not required, but doesn't work without it
end
def add_more_required_params(xml, options)
+ test_mode = options[:test_mode].nil? ? test? : options[:test_mode]
xml.tag! 'RETAIL_LANENUM', '0'
- xml.tag! 'TEST', 'TRUE' if test?
+ xml.tag! 'TEST', test_mode ? 'TRUE' : 'FALSE'
xml.tag! 'TOTAL_INSTALLMENTCOUNT', 0
xml.tag! 'TRANSACTION_SERVICE', 0
xml.tag! 'DEVELOPERID', options[:developer_id] if options[:developer_id]
end