paystation.rb in activemerchant-1.80.0

- old
+ new

@@ -1,10 +1,10 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PaystationGateway < Gateway
 
-      self.live_url = self.test_url = "https://www.paystation.co.nz/direct/paystation.dll"
+      self.live_url = self.test_url = 'https://www.paystation.co.nz/direct/paystation.dll'
 
       # an "error code" of "0" means "No error - transaction successful"
       SUCCESSFUL_RESPONSE_CODE = '0'
 
       # an "error code" of "34" means "Future Payment Stored OK"
@@ -102,13 +102,13 @@
 
         def new_request
           {
             :pi    => @options[:paystation_id], # paystation account id
             :gi    => @options[:gateway_id],    # paystation gateway id
-            "2p"   => "t",                      # two-party transaction type
-            :nr    => "t",                      # -- redirect??
-            :df    => "yymm"                    # date format: optional sometimes, required others
+            '2p'   => 't',                      # two-party transaction type
+            :nr    => 't',                      # -- redirect??
+            :df    => 'yymm'                    # date format: optional sometimes, required others
           }
         end
 
         def add_customer_data(post, options)
           post[:mc] = options[:customer]
@@ -126,31 +126,31 @@
           post[:ex] = format_date(credit_card.month, credit_card.year)
           post[:cc] = credit_card.verification_value if credit_card.verification_value?
         end
 
         def add_token(post, token)
-          post[:fp] = "t"    # turn on "future payments" - what paystation calls Token Billing
+          post[:fp] = 't'    # turn on "future payments" - what paystation calls Token Billing
           post[:ft] = token
         end
 
         def store_credit_card(post, options)
-          post[:fp] = "t"                                # turn on "future payments" - what paystation calls Token Billing
-          post[:fs] = "t"                                # tells paystation to store right now, not bill
+          post[:fp] = 't'                                # turn on "future payments" - what paystation calls Token Billing
+          post[:fs] = 't'                                # tells paystation to store right now, not bill
           post[:ft] = options[:token] if options[:token] # specify a token to use that, or let Paystation generate one
         end
 
         def add_authorize_flag(post, options)
-          post[:pa] = "t" # tells Paystation that this is a pre-auth authorisation payment (account must be in pre-auth mode)
+          post[:pa] = 't' # tells Paystation that this is a pre-auth authorisation payment (account must be in pre-auth mode)
         end
 
         def add_refund_specific_fields(post, authorization)
-          post[:rc] = "t"
+          post[:rc] = 't'
           post[:rt] = authorization
         end
 
         def add_authorization_token(post, auth_token, verification_value = nil)
-          post[:cp] = "t" # Capture Payment flag – tells Paystation this transaction should be treated as a capture payment
+          post[:cp] = 't' # Capture Payment flag – tells Paystation this transaction should be treated as a capture payment
           post[:cx] = auth_token
           post[:cc] = verification_value
         end
 
         def add_amount(post, money, options)
@@ -169,19 +169,19 @@
 
           response
         end
 
         def commit(post)
-          post[:tm] = "T" if test?
-          pstn_prefix_params = post.collect { |key, value| "pstn_#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+          post[:tm] = 'T' if test?
+          pstn_prefix_params = post.collect { |key, value| "pstn_#{key}=#{CGI.escape(value.to_s)}" }.join('&')
 
           data     = ssl_post(self.live_url, "#{pstn_prefix_params}&paystation=_empty")
           response = parse(data)
           message  = message_from(response)
 
           PaystationResponse.new(success?(response), message, response,
-              :test          => (response[:tm] && response[:tm].downcase == "t"),
+              :test          => (response[:tm] && response[:tm].downcase == 't'),
               :authorization => response[:paystation_transaction_id]
           )
         end
 
         def success?(response)
@@ -198,10 +198,10 @@
 
     end
 
     class PaystationResponse < Response
       def token
-        @params["future_payment_token"]
+        @params['future_payment_token']
       end
     end
   end
 end