ogone.rb in activemerchant-1.104.0

- old
+ new

@@ -211,11 +211,11 @@
         end
       end
 
       # Store a credit card by creating an Ogone Alias
       def store(payment_source, options = {})
-        options[:alias_operation] = 'BYPSP' unless(options.has_key?(:billing_id) || options.has_key?(:store))
+        options[:alias_operation] = 'BYPSP' unless options.has_key?(:billing_id) || options.has_key?(:store)
         response = authorize(@options[:store_amount] || 1, payment_source, options)
         void(response.authorization) if response.success?
         response
       end
 
@@ -237,10 +237,11 @@
         authorization.split(';').first
       end
 
       def reference_transaction?(identifier)
         return false unless identifier.is_a?(String)
+
         _, action = identifier.split(';')
         !action.nil?
       end
 
       def perform_reference_credit(money, payment_target, options = {})
@@ -320,10 +321,11 @@
         add_pair post, 'REMOTE_ADDR', options[:ip]
       end
 
       def add_address(post, creditcard, options)
         return unless options[:billing_address]
+
         add_pair post, 'Owneraddress', options[:billing_address][:address1]
         add_pair post, 'OwnerZip',     options[:billing_address][:zip]
         add_pair post, 'ownertown',    options[:billing_address][:city]
         add_pair post, 'ownercty',     options[:billing_address][:country]
         add_pair post, 'ownertelno',   options[:billing_address][:phone]
@@ -406,10 +408,10 @@
         parameters.to_query
       end
 
       def add_signature(parameters)
         if @options[:signature].blank?
-          ActiveMerchant.deprecated(OGONE_NO_SIGNATURE_DEPRECATION_MESSAGE) unless(@options[:signature_encryptor] == 'none')
+          ActiveMerchant.deprecated(OGONE_NO_SIGNATURE_DEPRECATION_MESSAGE) unless @options[:signature_encryptor] == 'none'
           return
         end
 
         add_pair parameters, 'SHASign', calculate_signature(parameters, @options[:signature_encryptor], @options[:signature])
       end