CONTRIBUTING.md in active_shipping-1.0.0.pre4 vs CONTRIBUTING.md in active_shipping-1.0.0
- old
+ new
@@ -7,20 +7,20 @@
Please use clean, concise code that follows Ruby community standards. For example:
- Be consistent
- Don't use too much white space
- Use 2 space indent, no tabs.
- - No spaces after (, [ and before ],)
+ - No spaces after `(`, `[` and before `]`, `)`
- Nor too little
- Use spaces around operators and after commas, colons and semicolons
- Indent when as deep as case
- Write lucid code in lieu of adding comments
### Pull request guidelines
- Add unit tests, and remote tests to make sure we won't introduce regressions to your code later on.
- Make sure CI passes for all Ruby versions and dependency versions we support.
-- XML handling: use `REXML` for parsing XML, and `builder` to generate it.
+- XML handling: use `Nokogiri.XML` for parsing XML, and `Nokogiri::XML::Builder` to generate it.
- JSON: use the JSON module that is included in Rubys standard ibrary
- HTTP: use `ActiveUtils`'s `PostsData`.
- Do not add new gem dependencies.
### Contributors