spec/acfs/stub_spec.rb in acfs-1.6.0 vs spec/acfs/stub_spec.rb in acfs-1.7.0

@@ -5,29 +5,32 @@
 class SpecialCustomError < StandardError; end
 
 describe Acfs::Stub do
   let(:stub) { Class.new(Acfs::Stub) }
 
-  before(:all) { Acfs::Stub.enable }
-  after(:all) { Acfs::Stub.disable }
+  before(:all) { Acfs::Stub.enable } # rubocop:disable RSpec/BeforeAfterAll
 
+  after(:all) { Acfs::Stub.disable } # rubocop:disable RSpec/BeforeAfterAll
+
   before do
     Acfs::Stub.allow_requests = false
   end
 
   describe '#called?' do
     context 'without specified number' do
-      let!(:operation) { Acfs::Stub.resource MyUser, :read, with: {id: 1}, return: {id: 1, name: 'John Smith', age: 32} }
+      let!(:operation) do
+        Acfs::Stub.resource MyUser, :read, with: {id: 1}, return: {id: 1, name: 'John Smith', age: 32}
+      end
 
-      it 'should allow to test if stub was called' do
+      it 'allows to test if stub was called' do
         MyUser.find 1
         Acfs.run
 
         expect(operation).to be_called
       end
 
-      it 'should allow to test if stub was called a specific number of times' do
+      it 'allows to test if stub was called a specific number of times' do
         MyUser.find 1
         Acfs.run
 
         MyUser.find 1
         Acfs.run
@@ -42,11 +45,11 @@
       before do
         Acfs::Stub.resource MyUser, :read, with: {id: 1}, return: {id: 1, name: 'John Smith', age: 32}
         Acfs::Stub.resource MyUser, :read, with: {id: 1}, raise: :not_found
       end
 
-      it 'should raise error' do
+      it 'raises error' do
         MyUser.find 1
 
         expect { Acfs.run }.to raise_error(Acfs::AmbiguousStubError)
       end
     end
@@ -56,27 +59,27 @@
         Acfs::Stub.resource MyUser, :read, with: {id: 1}, return: {id: 1, name: 'John Smith', age: 32}
         Acfs::Stub.resource MyUser, :read, with: {id: 2}, raise: SpecialCustomError
         Acfs::Stub.resource MyUser, :read, with: {id: 3}, raise: :not_found
       end
 
-      it 'should allow to stub resource reads' do
+      it 'allows to stub resource reads' do
         user = MyUser.find 1
         Acfs.run
 
-        expect(user.id).to be == 1
-        expect(user.name).to be == 'John Smith'
-        expect(user.age).to be == 32
+        expect(user.id).to eq 1
+        expect(user.name).to eq 'John Smith'
+        expect(user.age).to eq 32
       end
 
       context 'with error' do
-        it 'should allow to raise errors' do
+        it 'allows to raise errors' do
           MyUser.find 2
 
           expect { Acfs.run }.to raise_error(SpecialCustomError)
         end
 
-        it 'should allow to raise symbolic errors' do
+        it 'allows to raise symbolic errors' do
           MyUser.find 3
 
           expect { Acfs.run }.to raise_error(Acfs::ResourceNotFound)
         end
       end
@@ -85,11 +88,11 @@
         before do
           Acfs::Stub.resource Computer, :read, with: {id: 1}, return: {id: 1, type: 'PC'}
           Acfs::Stub.resource Computer, :read, with: {id: 2}, return: {id: 2, type: 'Mac'}
         end
 
-        it 'should create inherited type' do
+        it 'creates inherited type' do
           pc = Computer.find 1
           mac = Computer.find 2
 
           Acfs.run
 
@@ -99,22 +102,30 @@
       end
     end
 
     context 'with create action' do
       before do
-        Acfs::Stub.resource Session, :create, with: {ident: '[e-mail]', password: 's3cr3t'}, return: {id: 'longhash', user: 1}
-        Acfs::Stub.resource Session, :create, with: ->(op) { op.data[:ident] == '[e-mail]' && op.data[:password] == 'wrong' }, raise: 422
+        lmbd = lambda {|op|
+          op.data[:ident] == '[e-mail]' && op.data[:password] == 'wrong'
+        }
+
+        Acfs::Stub.resource Session, :create,
+          with: {ident: '[e-mail]', password: 's3cr3t'},
+          return: {id: 'longhash', user: 1}
+        Acfs::Stub.resource Session, :create,
+          with: lmbd,
+          raise: 422
       end
 
-      it 'should allow stub resource creation' do
+      it 'allows stub resource creation' do
         session = Session.create! ident: '[e-mail]', password: 's3cr3t'
 
-        expect(session.id).to be == 'longhash'
-        expect(session.user).to be == 1
+        expect(session.id).to eq 'longhash'
+        expect(session.user).to eq 1
       end
 
-      it 'should allow to raise error' do
+      it 'allows to raise error' do
         expect do
           Session.create! ident: '[e-mail]', password: 'wrong'
         end.to raise_error(::Acfs::InvalidResource)
       end
     end
@@ -123,18 +134,18 @@
       before do
         Acfs::Stub.resource MyUser, :list,
           return: [{id: 1, name: 'John Smith', age: 32}, {id: 2, name: 'Anon', age: 12}]
       end
 
-      it 'should return collection' do
+      it 'returns collection' do
         users = MyUser.all
         Acfs.run
 
         expect(users).to have(2).items
       end
 
-      it 'should return defined resources' do
+      it 'returns defined resources' do
         users = MyUser.all
         Acfs.run
 
         expect(users[0].id).to eq 1
         expect(users[1].id).to eq 2
@@ -146,64 +157,69 @@
         before do
           Acfs::Stub.resource Computer, :list,
             return: [{id: 1, type: 'PC'}, {id: 2, type: 'Mac'}]
         end
 
-        it 'should create inherited type' do
+        it 'creates inherited type' do
           computers = Computer.all
           Acfs.run
 
           expect(computers.first).to be_a PC
           expect(computers.last).to be_a Mac
         end
       end
 
       context 'with header' do
+        subject do
+          Acfs.run
+          comments
+        end
+
         before do
           Acfs::Stub.resource Comment, :list,
             return: [{id: 1, text: 'Foo'}, {id: 2, text: 'Bar'}],
             headers: headers
         end
 
         let!(:comments) { Comment.all }
         let(:headers) do
           {
             'X-Total-Pages' => '2',
-            'X-Total-Count' => '10'
+            'X-Total-Count' => '10',
           }
         end
-        subject { Acfs.run; comments }
 
-        its(:total_pages) { should eq 2 }
-        its(:total_count) { should eq 10 }
+        its(:total_pages) { is_expected.to eq 2 }
+        its(:total_count) { is_expected.to eq 10 }
       end
     end
 
     context 'with update action' do
       before do
         Acfs::Stub.resource MyUser, :read, with: {id: 1}, return: {id: 1, name: 'John Smith', age: 32}
-        Acfs::Stub.resource MyUser, :update, with: {id: 1, name: 'John Smith', age: 22}, return: {id: 1, name: 'John Smith', age: 23}
+        Acfs::Stub.resource MyUser, :update, with: {id: 1, name: 'John Smith', age: 22},
+          return: {id: 1, name: 'John Smith', age: 23}
         Acfs::Stub.resource MyUser, :update, with: {id: 1, name: 'John Smith', age: 0}, raise: 422
       end
 
       let!(:update_stub) do
         Acfs::Stub.resource MyUser, :update,
           with: {id: 1, name: 'Jane Smith'},
-          return: ->(op) { Hash[op.data.map {|k, v| [k, v.to_s.upcase] }] }
+          return: ->(op) { op.data.map {|k, v| [k, v.to_s.upcase] }.to_h }
       end
 
-      it 'should allow stub resource update' do
+      it 'allows stub resource update' do
         user = MyUser.find 1
         Acfs.run
 
         user.age = 22
         user.save!
 
-        expect(user.age).to be == 23
+        expect(user.age).to eq 23
       end
 
-      it 'should allow to raise error' do
+      it 'allows to raise error' do
         user = MyUser.find 1
         Acfs.run
 
         user.age = 0
         user.save
@@ -211,65 +227,53 @@
         expect do
           user.save!
         end.to raise_error(::Acfs::InvalidResource)
       end
 
-      it 'should match partial :with' do
+      it 'matches partial :with' do
         user = MyUser.find 1
         Acfs.run
 
         user.age = 5
         user.name = 'Jane Smith'
         user.save!
 
         expect(update_stub).to be_called
       end
 
-      it 'should process response body' do
+      it 'processes response body' do
         user = MyUser.find 1
         Acfs.run
 
         user.age = 5
         user.name = 'Jane Smith'
         user.save!
 
         expect(user.name).to eq 'JANE SMITH'
       end
     end
-
-    context 'with create action' do
-      before do
-        Acfs::Stub.resource MyUser, :create, with: {name: 'John Smith', age: 0}, raise: 422
-      end
-
-      it 'should allow to raise error' do
-        expect do
-          MyUser.create! name: 'John Smith', age: 0
-        end.to raise_error(::Acfs::InvalidResource)
-      end
-    end
   end
 
   describe '.allow_requests=' do
     context 'when enabled' do
       before do
         Acfs::Stub.allow_requests = true
         stub_request(:get, 'http://users.example.org/users/2').to_return response(id: 2, name: 'John', age: 26)
       end
 
-      it 'should allow real requests' do
+      it 'allows real requests' do
         @user = MyUser.find 2
-        expect { Acfs.run }.to_not raise_error
+        expect { Acfs.run }.not_to raise_error
       end
     end
 
     context 'when disabled' do
       before do
         Acfs::Stub.allow_requests = false
       end
 
-      it 'should not allow real requests' do
+      it 'does not allow real requests' do
         @user = MyUser.find 2
         expect { Acfs.run }.to raise_error(Acfs::RealRequestsNotAllowedError)
       end
     end
   end
@@ -277,11 +281,11 @@
   describe 'accept?' do
     subject { stub.accept?(op) }
 
     context 'with a match in params' do
       let(:op) do
-        double('operation').tap do |op|
+        instance_double('Acfs::Operation').tap do |op|
           allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
           allow(op).to receive(:data).and_return({})
         end
       end
 
@@ -290,11 +294,11 @@
       it { is_expected.to be true }
     end
 
     context 'with a match in data' do
       let(:op) do
-        double('operation').tap do |op|
+        instance_double('Acfs::Operation').tap do |op|
           allow(op).to receive(:full_params).and_return({})
           allow(op).to receive(:data).and_return(id: 1337, blub: 'abc')
         end
       end
 
@@ -303,11 +307,11 @@
       it { is_expected.to be true }
     end
 
     context 'with no match in params nor data' do
       let(:op) do
-        double('operation').tap do |op|
+        instance_double('Acfs::Operation').tap do |op|
           allow(op).to receive(:full_params).and_return(id: 1337)
           allow(op).to receive(:data).and_return({})
         end
       end
 
@@ -316,11 +320,11 @@
       it { is_expected.to be false }
     end
 
     context 'with a wrong match' do
       let(:op) do
-        double('operation').tap do |op|
+        instance_double('Acfs::Operation').tap do |op|
           allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
           allow(op).to receive(:data).and_return({})
         end
       end
 
@@ -329,10 +333,10 @@
       it { is_expected.to be false }
     end
 
     context 'with a missing match' do
       let(:op) do
-        double('operation').tap do |op|
+        instance_double('Acfs::Operation').tap do |op|
           allow(op).to receive(:full_params).and_return(id: 1337, blub: 'abc')
           allow(op).to receive(:data).and_return({})
         end
       end