test/access/favorite_test.rb in access-2.0.42 vs test/access/favorite_test.rb in access-2.0.43

@@ -34,23 +34,23 @@
   end
 
   def test_favorite_search_with_bad_member
     VCR.use_cassette('favorite search bad member') do
       request = Access::Favorite.search member_key: 'API_TEST_FAVORITE_BAD_MEMBER'
-      assert request.success
+      refute request.success
       assert_kind_of Access::FavoriteResponse, request
-      assert_nil request.favorites
+      assert_empty request.favorites
     end
   end
 
   def test_favorite_search_with_no_favorites
     # TODO refactor after fav api update
     VCR.use_cassette('favorite search no favorites') do
       request = Access::Favorite.search member_key: 'API_TEST_FAVORITE_NO_FAVORITES'
-      assert request.success
+      refute request.success
       assert_kind_of Access::FavoriteResponse, request
-      assert_nil request.favorites
+      assert_empty request.favorites
     end
   end
 
   def test_favorite_search_offers
     VCR.use_cassette('favorite search offers') do
@@ -153,19 +153,19 @@
 
   def test_favorite_delete_location
     VCR.use_cassette('favorite delete location') do
       Access::Favorite.delete_location @@offer.location.location_key, member_key: 'API_TEST' # create it first, in case it was deleted
       request = Access::Favorite.find_location @@offer.location.location_key, member_key: 'API_TEST'
-      assert request.success
+      refute request.success
       assert_kind_of Access::FavoriteResponse, request
     end
   end
 
   def test_favorite_delete_store
     VCR.use_cassette('favorite delete store') do
       Access::Favorite.delete_store @@offer.store.store_key, member_key: 'API_TEST' # create it first, in case it was deleted
       request = Access::Favorite.find_store @@offer.store.store_key, member_key: 'API_TEST'
-      assert request.success
+      refute request.success
       assert_kind_of Access::FavoriteResponse, request
     end
   end