Contents

# encoding: utf-8

module RuboCop
  module Cop
    module Lint
      # This cop checks for expressions where there is a call to a predicate
      # method with at least one argument, where no parentheses are used around
      # the parameter list, and a boolean operator, && or ||, is used in the
      # last argument.
      #
      # The idea behind warning for these constructs is that the user might
      # be under the impression that the return value from the method call is
      # an operand of &&/||.
      #
      # @example
      #
      #   if day.is? :tuesday && month == :jan
      #     ...
      #   end
      class RequireParentheses < Cop
        include IfNode

        MSG = 'Use parentheses in the method call to avoid confusion about ' \
              'precedence.'

        def on_send(node)
          _receiver, method_name, *args = *node

          return if parentheses?(node)
          return if args.empty?

          if ternary_op?(args.first)
            check_ternary(args.first, node)
          else
            # We're only checking predicate methods. There would be false
            # positives otherwise.
            check_send(args.last, node) if predicate?(method_name)
          end
        end

        private

        def check_ternary(arg, node)
          condition, _, _ = *arg
          return unless offense?(condition)

          expr = node.loc.expression
          range = Parser::Source::Range.new(expr.source_buffer,
                                            expr.begin_pos,
                                            condition.loc.expression.end_pos)
          add_offense(range, range)
        end

        def check_send(arg, node)
          add_offense(node, :expression) if offense?(arg)
        end

        def predicate?(method_name)
          method_name.to_s.end_with?('?')
        end

        def offense?(node)
          [:and, :or].include?(node.type)
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
rubocop-0.30.1	lib/rubocop/cop/lint/require_parentheses.rb
rubocop-0.30.0	lib/rubocop/cop/lint/require_parentheses.rb
rubocop-0.29.1	lib/rubocop/cop/lint/require_parentheses.rb
rubocop-0.29.0	lib/rubocop/cop/lint/require_parentheses.rb