Sha256: ff16d31c513fbd243018b12557157546c1f8feb6e166ac56ec5f0cae64c279b8
Contents?: true
Size: 1.31 KB
Versions: 13
Compression:
Stored size: 1.31 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop enforces the use of `ids` over `pluck(:id)` and `pluck(primary_key)`.
#
# @example
# # bad
# User.pluck(:id)
# user.posts.pluck(:id)
#
# def self.user_ids
# pluck(primary_key)
# end
#
# # good
# User.ids
# user.posts.ids
#
# def self.user_ids
# ids
# end
#
class PluckId < Base
include RangeHelp
include ActiveRecordHelper
extend AutoCorrector
MSG = 'Use `ids` instead of `%<bad_method>s`.'
RESTRICT_ON_SEND = %i[pluck].freeze
def_node_matcher :pluck_id_call?, <<~PATTERN
(send _ :pluck {(sym :id) (send nil? :primary_key)})
PATTERN
def on_send(node)
return if !pluck_id_call?(node) || in_where?(node)
range = offense_range(node)
message = format(MSG, bad_method: range.source)
add_offense(range, message: message) do |corrector|
corrector.replace(offense_range(node), 'ids')
end
end
private
def offense_range(node)
range_between(node.loc.selector.begin_pos, node.loc.expression.end_pos)
end
end
end
end
end
Version data entries
13 entries across 13 versions & 1 rubygems