Sha256: fd9543ee8d072c9a0e60e7e38b7064550d4cbeab25d6bc1bb1c3843b92a70db5

Contents?: true

Size: 1.66 KB

Versions: 11

Compression:

Stored size: 1.66 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module RSpec
      # Checks for `instance_double` used with `have_received`.
      #
      # @example
      #   # bad
      #   it do
      #     foo = instance_double(Foo).as_null_object
      #     expect(foo).to have_received(:bar)
      #   end
      #
      #   # good
      #   it do
      #     foo = instance_spy(Foo)
      #     expect(foo).to have_received(:bar)
      #   end
      #
      class InstanceSpy < Cop
        MSG = 'Use `instance_spy` when you check your double '\
              'with `have_received`.'

        def_node_search :null_double, <<-PATTERN
          (lvasgn $_
            (send
              $(send nil? :instance_double
                ...) :as_null_object))
        PATTERN

        def_node_search :have_received_usage, <<-PATTERN
          (send
            (send nil? :expect
            (lvar $_)) :to
            (send nil? :have_received
            ...)
          ...)
        PATTERN

        def on_block(node)
          return unless example?(node)

          null_double(node) do |var, receiver|
            have_received_usage(node) do |expected|
              add_offense(receiver) if expected == var
            end
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            replacement = 'instance_spy'
            corrector.replace(node.loc.selector, replacement)

            double_source_map = node.parent.loc
            as_null_object_range = double_source_map
              .dot
              .join(double_source_map.selector)
            corrector.remove(as_null_object_range)
          end
        end
      end
    end
  end
end

Version data entries

11 entries across 11 versions & 1 rubygems

Version Path
rubocop-rspec-1.41.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.40.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.39.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.38.1 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.38.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.37.1 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.37.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.36.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.35.0 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.34.1 lib/rubocop/cop/rspec/instance_spy.rb
rubocop-rspec-1.34.0 lib/rubocop/cop/rspec/instance_spy.rb