Sha256: fabc79d70af2a7da4e5beca75a13a88b14e79521abb4fda2c57c61cf0786a859
Contents?: true
Size: 1.54 KB
Versions: 28
Compression:
Stored size: 1.54 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# Checks for uses of if/unless modifiers with multiple-lines bodies.
#
# @example
#
# # bad
# {
# result: 'this should not happen'
# } unless cond
#
# # good
# { result: 'ok' } if cond
class MultilineIfModifier < Base
include StatementModifier
include Alignment
extend AutoCorrector
MSG = 'Favor a normal %<keyword>s-statement over a modifier ' \
'clause in a multiline statement.'
def on_if(node)
return unless node.modifier_form? && node.body.multiline?
add_offense(node, message: format(MSG, keyword: node.keyword)) do |corrector|
corrector.replace(node, to_normal_if(node))
end
end
private
def to_normal_if(node)
indented_body = indented_body(node.body, node)
condition = "#{node.keyword} #{node.condition.source}"
indented_end = "#{offset(node)}end"
[condition, indented_body, indented_end].join("\n")
end
def configured_indentation_width
super || 2
end
def indented_body(body, node)
body_source = "#{offset(node)}#{body.source}"
body_source.each_line.map do |line|
if line == "\n"
line
else
line.sub(/^\s{#{offset(node).length}}/, indentation(node))
end
end.join
end
end
end
end
end
Version data entries
28 entries across 24 versions & 3 rubygems