Sha256: fa19157e1a9dd778fcddcb2e3372a877c57f2a5123df48ee02b578a971edd713
Contents?: true
Size: 1.81 KB
Versions: 22
Compression:
Stored size: 1.81 KB
Contents
#
# Copyright:: 2019, Chef Software, Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
module Cop
module Chef
module ChefCorrectness
# Valid notification timings are :immediately, :immediate (alias for :immediately), :delayed, and :before.
#
# @example
#
# # bad
#
# template '/etc/www/configures-apache.conf' do
# notifies :restart, 'service[apache]', :nope
# end
#
# # good
#
# template '/etc/www/configures-apache.conf' do
# notifies :restart, 'service[apache]', :immediately
# end
#
class InvalidNotificationTiming < Cop
MSG = 'Valid notification timings are :immediately, :immediate (alias for :immediately), :delayed, and :before.'.freeze
def_node_matcher :notification_with_timing?, <<-PATTERN
(send nil? {:notifies :subscribes} (sym _) (...) $(sym _))
PATTERN
def on_send(node)
notification_with_timing?(node) do |timing|
add_offense(timing, location: :expression, message: MSG, severity: :refactor) unless %i(immediate immediately delayed before).include?(timing.value)
end
end
end
end
end
end
end
Version data entries
22 entries across 22 versions & 1 rubygems