Sha256: f300a3fed28b4c4c9c03a0b0b5d31f34860d3d6e247f531cbb042bc47d25d8f2
Contents?: true
Size: 1018 Bytes
Versions: 36
Compression:
Stored size: 1018 Bytes
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop checks for uses of "*" as a substitute for *join*.
#
# Not all cases can reliably checked, due to Ruby's dynamic
# types, so we consider only cases when the first argument is an
# array literal or the second is a string literal.
#
# @example
#
# # bad
# %w(foo bar baz) * ","
#
# # good
# %w(foo bar baz).join(",")
#
class ArrayJoin < Cop
MSG = 'Favor `Array#join` over `Array#*`.'
def_node_matcher :join_candidate?, '(send $array :* $str)'
def on_send(node)
join_candidate?(node) { add_offense(node, location: :selector) }
end
def autocorrect(node)
array, join_arg = join_candidate?(node).map(&:source)
lambda do |corrector|
corrector.replace(node.source_range, "#{array}.join(#{join_arg})")
end
end
end
end
end
end
Version data entries
36 entries across 19 versions & 2 rubygems