Sha256: f1ce625d66e41bb336e79f5b0c2ae536c16981962a7d4aa3ead9e9df42f457dc
Contents?: true
Size: 1.29 KB
Versions: 128
Compression:
Stored size: 1.29 KB
Contents
# frozen_string_literal: true
require_relative "base_cop"
module GraphQL
module Rubocop
module GraphQL
# Identify (and auto-correct) any field configuration which duplicates
# the default `null: true` property.
#
# `null: true` is default because nullable fields can always be converted
# to non-null fields (`null: false`) without a breaking change. (The opposite change, from `null: false`
# to `null: true`, change.)
#
# @example
# # Both of these define `name: String` in GraphQL:
#
# # bad
# field :name, String, null: true
#
# # good
# field :name, String
#
class DefaultNullTrue < BaseCop
MSG = "`null: true` is the default and can be removed."
def_node_matcher :field_config_with_null_true?, <<-Pattern
(
send nil? :field ... (hash $(pair (sym :null) (true)) ...)
)
Pattern
def on_send(node)
field_config_with_null_true?(node) do |null_config|
add_offense(null_config) do |corrector|
cleaned_node_source = source_without_keyword_argument(node, null_config)
corrector.replace(node.source_range, cleaned_node_source)
end
end
end
end
end
end
end
Version data entries
128 entries across 128 versions & 2 rubygems