Contents

# encoding: utf-8

module RuboCop
  module Cop
    module Style
      # This cop checks for the use of a method, the result of which
      # would be a literal, like an empty array, hash or string.
      class EmptyLiteral < Cop
        ARR_MSG = 'Use array literal `[]` instead of `Array.new`.'
        HASH_MSG = 'Use hash literal `{}` instead of `Hash.new`.'
        STR_MSG = "Use string literal `''` instead of `String.new`."

        # Empty array node
        #
        # (send
        #   (const nil :Array) :new)
        ARRAY_NODE = s(:send, s(:const, nil, :Array), :new)

        # Empty hash node
        #
        # (send
        #   (const nil :Hash) :new)
        HASH_NODE = s(:send, s(:const, nil, :Hash), :new)

        # Empty string node
        #
        # (send
        #   (const nil :String) :new)
        STR_NODE = s(:send, s(:const, nil, :String), :new)

        def on_send(node)
          return if part_of_ignored_node?(node)

          case node
          when ARRAY_NODE
            add_offense(node, :expression, ARR_MSG)
          when HASH_NODE
            add_offense(node, :expression, HASH_MSG)
          when STR_NODE
            add_offense(node, :expression, STR_MSG)
          end
        end

        # TODO: Check block contents as well.
        alias_method :on_block, :ignore_node

        def autocorrect(node)
          @corrections << lambda do |corrector|
            name = case node
                   when ARRAY_NODE then '[]'
                   when HASH_NODE then '{}'
                   when STR_NODE then "''"
                   end
            corrector.replace(node.loc.expression, name)
          end
        end
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
rubocop-0.28.0	lib/rubocop/cop/style/empty_literal.rb
rubocop-0.27.1	lib/rubocop/cop/style/empty_literal.rb