Contents

require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')

describe Simplabs::Excellent::Checks::AssignmentInConditionalCheck do

  before do
    @excellent = Simplabs::Excellent::Core::ParseTreeRunner.new(Simplabs::Excellent::Checks::AssignmentInConditionalCheck.new)
  end

  describe '#evaluate' do

    it 'should accept an assignment before an if clause' do
      content = <<-END
        count = count += 1 if some_condition
      END
      @excellent.check_content(content)

      @excellent.errors.should be_empty
    end

    it 'should reject an assignment inside an if clause' do
      content = <<-END
        call_foo if bar = bam
      END

      verify_error_found(content)
    end

    it 'should reject an assignment inside an unless clause' do
      content = <<-END
        call_foo unless bar = bam
      END

      verify_error_found(content)
    end

    it 'should reject an assignment inside a while clause' do
      content = <<-END
        call_foo while bar = bam
      END

      verify_error_found(content)
    end

    it 'should reject an assignment inside an until clause' do
      content = <<-END
        call_foo until bar = bam
      END

      verify_error_found(content)
    end

    it 'should reject an assignment inside a ternary operator check clause' do
      content = <<-END
        call_foo (bar = bam) ? baz : bad
      END

      #RubyParser sets line number 2 here
      verify_error_found(content, 2)
    end

  end

  def verify_error_found(content, line_number = nil)
    @excellent.check_content(content)
    errors = @excellent.errors

    errors.should_not be_empty
    errors[0].info.should        == {}
    errors[0].line_number.should == (line_number || 1)
    errors[0].message.should     == 'Assignment in condition.'
  end

end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
simplabs-excellent-1.0.0	spec/checks/assignment_in_conditional_check_spec.rb
simplabs-excellent-1.0.1	spec/checks/assignment_in_conditional_check_spec.rb