Contents

require 'rails_best_practices/checks/check'

module RailsBestPractices
  module Checks
    # Check a view file to make sure there is no finder.
    #
    # Implementation: Check if view file contains finder, then the code should move to controller.
    class MoveCodeIntoControllerCheck < Check
      
      FINDER = [:find, :all, :first, :last]
      
      def interesting_nodes
        [:call]
      end
      
      def interesting_files
        VIEW_FILES
      end
      
      def evaluate_start(node)
        add_error "move code into controller" if finder?(node)
      end
      
      private

      def finder?(node)
        node.subject.node_type == :const && FINDER.include?(node.message)
      end
    end
  end
end

Version data entries

34 entries across 34 versions & 1 rubygems

Version	Path
rails_best_practices-0.3.10	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.9	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.8	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.7	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.6	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.5	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.4	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.3	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.2	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.1	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.3.0	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.2.16	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.2.15	lib/rails_best_practices/checks/move_code_into_controller_check.rb
rails_best_practices-0.2.14	lib/rails_best_practices/checks/move_code_into_controller_check.rb