Sha256: eaeba4ac872e40f36fdec6785378a4d5ccb5dc80b70f3a92a644448d5148471e

Contents?: true

Size: 1.13 KB

Versions: 24

Compression:

Stored size: 1.13 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Rails
      # Checks that ActiveRecord aliases are not used. The direct method names
      # are more clear and easier to read.
      #
      # @example
      #   #bad
      #   Book.update_attributes!(author: 'Alice')
      #
      #   #good
      #   Book.update!(author: 'Alice')
      class ActiveRecordAliases < Cop
        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze

        ALIASES = {
          update_attributes: :update,
          update_attributes!: :update!
        }.freeze

        def on_send(node)
          ALIASES.each do |bad, good|
            next unless node.method?(bad)

            add_offense(node,
                        message: format(MSG, prefer: good, current: bad),
                        location: :selector,
                        severity: :warning)
            break
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            corrector.replace(
              node.loc.selector,
              ALIASES[node.method_name].to_s
            )
          end
        end
      end
    end
  end
end

Version data entries

24 entries across 22 versions & 3 rubygems

Version Path
rubocop-0.63.1 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.63.0 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.62.0 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.61.1 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.61.0 lib/rubocop/cop/rails/active_record_aliases.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/rails/active_record_aliases.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/rails/active_record_aliases.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/rails/active_record_aliases.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.60.0 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.59.2 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.59.1 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.59.0 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.58.2 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.58.1 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.58.0 lib/rubocop/cop/rails/active_record_aliases.rb
vagrant-packet-0.1.1 vendor/bundle/ruby/2.4.0/gems/rubocop-0.57.2/lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.57.2 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.57.1 lib/rubocop/cop/rails/active_record_aliases.rb
rubocop-0.57.0 lib/rubocop/cop/rails/active_record_aliases.rb